Quinton Miller comments

Results 414 comments of


                                            Quinton Miller

`Tuple.new` isn't considered an `Enumerable`

How would unions between them work if they are no longer covariant?

Undefined variables when declared within macro expression

For the local variable case I think it is good to be explicit here. We could declare `x` to be a variable with no fixed type: ```crystal x : _...

Undefined variables when declared within macro expression

Apart from semantic correctness, this has the benefit that parsers and tools which don't rely on semantic analysis may determine whether the `x` in the `puts` call is a variable...

Add icon and metadata to Windows Crystal compiler binary

The favicon was originally at 128x128

Automatic casting of non-Nil proc return type to Nil is wrong for struct types

It seems the `Proc`s that return large structs do expect the stack to be set up by the caller: https://godbolt.org/z/E5qvP6GPb I think it is okay to create a wrapper closure...

Using --no-codegen blocks --emit options

For the Compiler Explorer it would be very useful if the assembly and the IR can both be generated without actually compiling / linking that into a binary or `.o`...

type mismatch at src/crystal/main.cr

An `Exception` is an `Exception?` though. What does the actual error look like?

type mismatch at src/crystal/main.cr

Duplicate of crystal-lang-tools/scry#186. It seems it might have happened because `Exception` here refers to [`Crystal::Exception`](https://github.com/crystal-lang-tools/scry/blob/8e8e822470a942c1f8fbf5b4653a17b30674499f/src/scry/missing_methods.cr#L10-L16), but the same class in the Crystal compiler has been renamed to `Crystal::CodeError` in #10197....

Allow calling `Enum.parse?` and `.from_value?` via `super` from overide in enum types

If we allow: ```crystal struct Value def self.foo : self? end end struct Char def self.foo : self? super end end Char.foo # => nil ``` There is no reason...

Allow calling `Enum.parse?` and `.from_value?` via `super` from overide in enum types

I looked into this a bit and in the first case the compiler actually forms the union between `Value+` and `Nil`, and that doesn't produce an error for some reason....