Quinton Miller comments

Results 414 comments of


                                            Quinton Miller

Should `Pointer(T)#==` always compare the address, regardless of `T`?

`Pointer(T)` includes `Comparable(self)`, so it defines a `#==(other : self)` method; since this `self` is equivalent to `Pointer(T)`, and since this `T` is covariant in a type restriction, the second...

`StringLiteral#to_i` with a number kind

Passing `:f32` or `:f64` to the kind parameter would be an error, but then it would be somewhat odd to add a separate `StringLiteral#to_f` that does a similar conversion, only...

`StringLiteral#to_i` returns unusable `NumberLiteral`s on value overflow

By the way, one existing workaround is `{{ 0_i64 + parse_type("Foo(#{str.id})").type_vars[0] }}`.

`Slice.new` without init value should work with `Pointer` types instead of only `Number::Primitive`

The mere mention of `Pointer` puts your code in unsafe territory, whichever constructor is used. This is mostly about making such code more ergonomic because pointers have relatively straightforward ABI...

Better handle free vars and unknown types in abstract defs

> just `def foo(x)` to satisfy `abstract def foo(x : U) : U forall U` IMO this should be legal with or without a return type in the abstract def,...

Better handle free vars and unknown types in abstract defs

Is this comment meant for #16430 instead...?

Fix interpreter when inlining pure `InstanceVar` virtual def and only one concrete subclass exists

In compiled code, When a def's body is exactly an `InstanceVar` node, `Crystal::CodeGenVisitor#try_inline_call` inlines calls to that def such that the calls act like a `ReadInstanceVar` instead, for both improving...

StringScanner#scan(Int), #skip(Int), #current_char, etc, and significantly speed up operations on multibyte characters

Related: #11259

ArithmeticError when accessing an Indexable with an empty unsigned range with exclude-end

Related: #13648

Block Type Annotations Break Access to `$~` in Blocks Without Parameters

A workaround is to assign `$~` to itself before the yield. This might have been a known issue since the standard library has been doing this for a very long...