Quinton Miller

Results 253 comments of Quinton Miller

Doing the byte loop before the unrolled loop does not matter, because if the first invalid byte occurs within the first unrolled chunk, then the method now visits `bytes.size %...

Crystal 1.0.0 cannot handle `UInt64`s inside the `dfa_state` macro until #10713. :thinking:

```crystal (0...9).to_a.each_cartesian((0...9).to_a, (0...9).to_a) do |(i, j, k)| # ... end ```

If performance really does matter, you could use a macro: ```crystal macro each_many(*exprs, &block) {% for expr, i in exprs %} %iter{i} = {{ expr }} {% end %} {%...

Related: https://github.com/crystal-lang/crystal/pull/12457#issuecomment-1239903346

It looks like LLVM's CMakeLists.txt doesn't support `BUILD_SHARED_LIBS` on MSVC: https://llvm.org/docs/CMake.html#llvm-related-variables It does have a `LLVM_BUILD_LLVM_C_DYLIB` variable which produces `Release\lib\LLVM-C.lib` and `Release\bin\LLVM-C.dll`. I do not know whether this DLL is...

Is this essentially [`POSIXLY_CORRECT` argument parsing](https://github.com/crystal-lang/crystal/issues/5845)?

It seems fields can only be serialized to / deserialized from node children, never attributes. Would attributes be covered by another annotation?

`String.empty?` refers to a _class_ method. The `#` is correct when used to refer to an _instance_ method. This convention comes from Ruby; our docs should indeed be friendlier towards...