HeroicGamesLauncher
HeroicGamesLauncher copied to clipboard
alphabet filter
Adding a video here to better overview:
Gravação de tela de 2025-06-09 14-43-24.webm
Use the following Checklist if you have changed something on the Backend or Frontend:
- [x] Tested the feature and it's working on a current and clean install.
- [ ] Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
- [ ] Created / Updated Tests (If necessary)
- [ ] Created / Updated documentation (If necessary)
@theguy000
ACtually found only one small issue on small screens:
Maybe make it wrap so it can break into 2 lines.
One comment after a quick test, games like [REDACTED] or >observer_ won't match any of the letters
maybe the title should be cleaned before comparing with the selected letter removing anything that is not A-Z or a digit, I would expect [REDACTED] to be in the R and >observer_ to be in the O
there seems to be on indicator of the currently selected letter, here I'm showing letter W and there's no difference between the W and the other letters
something is off with the games used for the letters enable/disable and the actual games in the results when using the search
here you can see that if I search 2023, I should have the W enabled because I have that game, but the letters are using the results of some previous search and not the current search, cause it shows M for metro exodus 2033 (which doesn't match the 2023 I typed, but probably matched the previous 2 character, or related to the fuzzy search feature?)
EDIT: I think this one can be ignored, I don't know if there's a way to fix this since the search uses the whole library and the list only uses what's being filtered/categorized/etc, and there's also some fuzzy search going on
if you are filtering by a letter (let's say X for example) and you make a search that does not return any result starting with that letter, that letter can't be clicked to unselect it because it's disabled, so you have to click another letter and unclick that again to reset the letter filter if you want to see all results
maybe we can make this visible with a toggle? like adding a button here to show/hide the letters
I can imagine people wanting to keep the current behavior and save that vertical space (not just for the space, but also to remove content for spatial navigation with a controller if you don't use it)
contrast of letters looks off when using the Nord Light theme (enabled letters look disabled, disabled letters look enabled, and hovering turns text white and can't be read)
Here you can see the Z is actually disabled cause I have no game starting with Z, and the L is where my mouse pointer is an you can barely see it
hey @arielj thank you for your response! I have added the changes you requested. please let me know if everything works.
also i have a question. i am a noob using git. can you please tell me why test:e2e is failing?
also i have a question. i am a noob using git. can you please tell me why test:e2e is failing?
e2e tests are flaky, they fail sometimes and in general it can be ignored, you can always run those tests locally to double check if they fail consistently or if they are just flaky
- better refactoring of src/frontend/screens/Library/index.tsx
- removed dark light themeing logic. instead, used css vars.
- used library context instead of prop drilling for the alphabetfilter btn
My bad @arielj , I thought I pushed to the dev branch in my fork with the changes and solved these issues (which I did). It seems like removing "Refresh" string from public/locales/en/translation.json caused my push to be failed (which I didn't notice)