HeroicGamesLauncher icon indicating copy to clipboard operation
HeroicGamesLauncher copied to clipboard

warn when WinePrefixesBasePath is empty

Open pt8o opened this issue 6 months ago • 2 comments

Resolves https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/issues/2556

Screenshot from 2024-08-12 18-22-53

Since all of these settings are saved on edit (rather than waiting for the user to hit a "Save" button or something) I didn't think there was a great way UX-wise to prevent the user from saving an empty folder. Instead I opted to display a warning below the input, and a button to revert to the most recent non-empty path. But the user can still ignore it and save the empty path.

If the user has already saved an empty path and then opens Settings, then there is no recent non-empty path, so the warning still appears but the undo button doesnt.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • [x] Tested the feature and it's working on a current and clean install.
  • [x] Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • [ ] Created / Updated Tests (If necessary)
  • [ ] Created / Updated documentation (If necessary)

pt8o avatar Aug 12 '24 22:08 pt8o