HeroicGamesLauncher icon indicating copy to clipboard operation
HeroicGamesLauncher copied to clipboard

Add support for more settings in known fixes .json files

Open Alerymin opened this issue 1 year ago • 7 comments

Problem description

I want to create a file for Return to Castle Wolfenstein, but I need to change the folder name (because the autogenerated one is broken for some reason) and some environment variables. But I cannot do it. See: https://github.com/Heroic-Games-Launcher/known-fixes/issues/6

Feature description

Add support for setting as a fix:

  • Select Wine version (which should preferably not lead to choosing proton)
  • Enable Esync
  • Enable Fsync
  • Prefer system libraries
  • BattleEye AntiCheat
  • EasyAntiCheat
  • Game arguments
  • Wrapper commands
  • Environment variables
  • Prefered Language

Alternatives

No response

Additional information

All the settings I listed are editable by the user, maybe all of them is not ideal or some may need to be added, but these will help making games work out of the box.

Alerymin avatar Feb 10 '24 22:02 Alerymin

(because the autogenerated one is broken for some reason)

What do you mean by this. According to the manifest, the install directory is Return to Castle Wolfenstein/. I think that's set properly

imLinguin avatar Feb 10 '24 22:02 imLinguin

When installing, it adds a space after the name, so the folder name ends with a space, which breaks winetricks

Alerymin avatar Feb 10 '24 22:02 Alerymin

There is indeed a space in the name image

Alerymin avatar Feb 10 '24 22:02 Alerymin

oh, so it causes issues with the prefix itself

imLinguin avatar Feb 10 '24 22:02 imLinguin

Yes, the issue is in the prefix, and winetricks hates it image

Alerymin avatar Feb 10 '24 23:02 Alerymin

Ideally we shouldn't save prefix like that into the config in the first place. That shouldn't be dictated by known-fixes.

imLinguin avatar Feb 10 '24 23:02 imLinguin

ok, so this should be fixed in Heroic directly

Alerymin avatar Feb 10 '24 23:02 Alerymin