HeroicGamesLauncher icon indicating copy to clipboard operation
HeroicGamesLauncher copied to clipboard

[Fix] Windows development fixes

Open HamsterExAstris opened this issue 1 year ago • 3 comments

Prettier forces all files to have Unix (LF) line endings. When a Windows user has core.autocrlf set to true in their global .gitconfig, commits use LF line endings but the files on disk use CRLF. This leads to spurious Prettier differences, causing the commit hook to fail.

This overrides that global setting, using LF endings for text files on disk regardless of the core.autocrlf setting.

It also fixes some tests that assumed Unix directory separators.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • [X] Tested the feature and it's working on a current and clean install.
  • [X] Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • [X] Created / Updated Tests (If necessary)
  • [ ] Created / Updated documentation (If necessary)

HamsterExAstris avatar Jan 21 '24 02:01 HamsterExAstris

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

flavioislima avatar Jan 21 '24 02:01 flavioislima

I have read the CLA Document and I hereby sign the CLA

HamsterExAstris avatar Jan 21 '24 02:01 HamsterExAstris

Question: this supposed to fix the issue where when we try yarn prettier-fix it changed the permission for all files in the repo?

flavioislima avatar Apr 07 '24 19:04 flavioislima