HeroicGamesLauncher icon indicating copy to clipboard operation
HeroicGamesLauncher copied to clipboard

Published 20 hours ago • verified publisher icon Heroic-Games-Launcher

Move `Tools` content into a menu

Open arielj opened this issue 2 years ago • 2 comments

This PR changes the layout of the game page to show the actions that are currently in the Tools tab in a menu triggered by a "hamburger" button on the corner. Hopefully this helps with the discoverability of the options.

Changes:

  • Moved most actions into the menu
  • Moved store logo to the bottom left
  • Moved the Requirements as a menu option and a Dialog
  • Moved Wine and WinePrefix path to the main info
  • Fixed an issue where the First/Last/Time Played was grabbing the controller focus incorrectly.

I tested also with a controller.

image image

Use the following Checklist if you have changed something on the Backend or Frontend:

  • [ ] Tested the feature and it's working on a current and clean install.
  • [ ] Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • [ ] Created / Updated Tests (If necessary)
  • [ ] Created / Updated documentation (If necessary)

arielj avatar Sep 23 '22 22:09 arielj

@biliesilva can you check the design and maybe add a mockup for the position of the Menu?

flavioislima avatar Sep 24 '22 13:09 flavioislima

Is it possible to make the hamburger menu a little less big or add an icon for options (3 dots) and also give more spacing between the lines of the text? It's easier to read with slightly larger spacing. Also, It would be nice to increase the weight of some parts of the text: image

biliesilva avatar Sep 24 '22 14:09 biliesilva

I applied the suggestions, it looks like this now: image

Any suggestion on where to put the menu button to try alternatives? I tried in other places but they looked really bad to me so I don't know what alternatives you would like to see.

arielj avatar Oct 07 '22 05:10 arielj

Some alternatives: image image image image

arielj avatar Oct 07 '22 05:10 arielj

The first option is more close to the convention.

biliesilva avatar Oct 07 '22 06:10 biliesilva

I vote for the first option as well. I noticed that the Store logo was removed from the game page, maybe we could add it again in another place, maybe with the title or at the bottom of the screen?

flavioislima avatar Oct 08 '22 14:10 flavioislima

I vote for the first option as well. I noticed that the Store logo was removed from the game page, maybe we could add it again in another place, maybe with the title or at the bottom of the screen?

by first option you mean the first I posted (the current code, at the top right corner) or the first alternative (the second comment that is not the current code, at the right side of the game title)?

the store logo is currently at the bottom left, I can put at the bottom right maybe, or put it back at the top right

arielj avatar Oct 08 '22 15:10 arielj

I vote for the first option as well. I noticed that the Store logo was removed from the game page, maybe we could add it again in another place, maybe with the title or at the bottom of the screen?

by first option you mean the first I posted (the current code, at the top right corner) or the first alternative (the second comment that is not the current code, at the right side of the game title)?

the store logo is currently at the bottom left, I can put at the bottom right maybe, or put it back at the top right

I mean this one: image

biliesilva avatar Oct 08 '22 15:10 biliesilva