Heroic must have an active connection when started.

[zany130]

Describe the bug

as the title says opening heroic before you have an active working connection (this happens on my garuda kde system) prevents game downloads and other connection-related things from working

Add logs

(14:39:29) DEBUG:   [Legendary]:       Running Legendary command: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary --version
(14:39:30) INFO:    [Legendary]:       Legendary location: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/legendary
(14:39:30) INFO:    [Gog]:             GOGDL location: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
(14:39:30) INFO:    [Backend]:         

Heroic Version: 2.3.9 Brook
Legendary Version:  0.20.26 Dark Energy
OS: Garuda KERNEL: 5.18.3-zen1-1-zen ARCH: x64
CPU: AMD Ryzen 5 2600X Six-Core Processor @3.6 GOVERNOR: performance
RAM: Total: 31.27 GiB Available: 26.58 GiB
GRAPHICS: GPU0: Navi 22 [Radeon RX 6700/6700 XT/6750 XT / 6800M] VRAM: 1MB DRIVER:  
PROTOCOL: wayland

(14:39:30) INFO:    [Backend]:         User Not Found, removing it from Store
(14:39:30) INFO:    [Gog]:             Getting data about the user
(14:39:33) WARNING: [Backend]:         Protocol already registered.
(14:39:33) ERROR:   [Gog]:             Error getting user Data Error: getaddrinfo ENOTFOUND embed.gog.com
(14:39:33) WARNING: [Backend]:         Error Downloading Winetricks
(14:39:34) INFO:    [Frontend]:        Refreshing Library
(14:39:34) INFO:    [Legendary]:       Refreshing library...
(14:39:34) INFO:    [Gog]:             Getting GOG library
(14:39:34) ERROR:   [Gog]:             There was an error getting games library data getaddrinfo ENOTFOUND embed.gog.com
(14:39:34) ERROR:   [Gog]:             There was an error Loading games library
(14:39:34) ERROR:   [Frontend]:        Error: Error invoking remote method 'checkGameUpdates': Error: getaddrinfo ENOTFOUND content-system.gog.com
(14:41:21) INFO:    [Gog]:             Getting game metadata: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/gogdl info 1212177362 --token <redacted> --lang=en-US --os windows
(14:41:21) DEBUG:   [Gog]:             Running GOGDL command: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/gogdl info 1212177362 --token <redacted> --lang=en-US --os windows
(14:41:21) INFO:    [Gog]:             Getting game metadata: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/gogdl info 1212177362 --token <redacted> --lang=en-US --os windows
(14:41:21) DEBUG:   [Gog]:             Running GOGDL command: /opt/Heroic/resources/app.asar.unpacked/build/bin/linux/gogdl info 1212177362 --token <redacted> --lang=en-US --os windows
(14:41:21) WARNING: [Backend]:         default is not writable
(14:41:22) ERROR:   [Backend]:         TypeError: Cannot set properties of undefined (setting 'folder_name')
(14:41:22) ERROR:   [Backend]:         TypeError: Cannot set properties of undefined (setting 'folder_name')

Steps to reproduce

1. open heroic before you have a working connection
2. try to download a game
3. See black error
4. go into logs and see several connection errors

Expected behavior

Heroic is able to retry its internet connectivity after launch

Screenshots

No response

System Information

• OS : Garuda Linux KDE
• Heroic Version : 2.3.9

Additional information

No response

[adityaruplaha]

Isn't this expected? Well I suppose it should be possible to check connectivity at startup.

[zany130]

the problem is that it leaves heroic in a broken state and you have to relaunch it. So for now I have a script which I launch at startup which waits 10 seconds then launches heroic so that it doesn't launch in a broken state.

what I mean by my expected behavior is that heroic shouldn't break when there no internet connection it should simply try connecting again later when there is

[flavioislima]

I can confirm this bug. Also, GOG game pages are not even open when offline. We will fix that before the next stable release.

[flavioislima]

@zany130 can you try this build: https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/actions/runs/2819413392 ?

It is fixed for me the issue. With this change heroic now ping some servers to see if it is actually online.

[zany130]

hmm achtually i can't reporduce the issue anymore on

pacman -Qi heroic-games-launcher-bin
Name            : heroic-games-launcher-bin
Version         : 2.4.0-2
Description     : HGL, a Native alternative Linux Launcher for Epic Games
Architecture    : x86_64
URL             : https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher
Licenses        : GPL3
Groups          : None
Provides        : None
Depends On      : fuse2  gawk
Optional Deps   : None
Required By     : None
Optional For    : None
Conflicts With  : heroic-games-launcher-appimage
                  heroic-games-launcher-electron
Replaces        : None
Installed Size  : 422.75 MiB
Packager        : UFSCar HPC Builder <[email protected]>
Build Date      : Thu 11 Aug 2022 10:05:17 PM EDT
Install Date    : Fri 12 Aug 2022 04:44:00 PM EDT
Install Reason  : Explicitly installed
Install Script  : No
Validated By    : Signature

hadn't noticed since i had it setup to start after a few minutes so there would be an active internet connection. Does this version have any changes for this?

[flavioislima]

nice, thanks