HeroicGamesLauncher icon indicating copy to clipboard operation
HeroicGamesLauncher copied to clipboard

Show progress when moving a game

Open flavioislima opened this issue 3 years ago • 6 comments

Problem description

Right now when moving games to another folder we don't have any feedback besides a message showing: Moving.... That's because we are using the mv. On Linux and macOS we have the rsync utility that has the --progress flag that shows a percent with the current progress. So we should change the command to use it instead.

On Windows I never heard of a utility like that that comes natively with powershell, for instance, so I don't know how to proceed there.

Feature description

Show progress information like we are doing with installs, so a progress bar + percentage.

Alternatives

No response

Additional information

No response

flavioislima avatar Jun 10 '22 11:06 flavioislima

Resources to try on Windows: https://stackoverflow.com/questions/2434133/progress-during-large-file-copy-copy-item-write-progress

flavioislima avatar Jun 10 '22 11:06 flavioislima

rsync is not preinstalled on every Linux distro. I would suggest just to loop through the folder and move each file without using a external program.

JakobDev avatar Jun 10 '22 12:06 JakobDev

Hmm, that makes sense. The problem with counting files is that some files are bigger than others so things wont be really precise. But could work on all platforms.

flavioislima avatar Jun 10 '22 13:06 flavioislima

@JakobDev for what I did search it is available on the great majority of distros by default. So I think we should still use rsync and if the command is not available, we show a warning and use mv instead. I think that's the best approach.

flavioislima avatar Jun 10 '22 15:06 flavioislima

just wondering, is there a reason we use move directly and not legendary's move command? (haven't tried moving a game with either heroic or legendary to compare though, maybe legendary just uses mv)

arielj avatar Jun 10 '22 22:06 arielj

Two reasons: won't work for GOG and don't support moving across devices.

flavioislima avatar Jun 11 '22 08:06 flavioislima

duplicated of #1091

flavioislima avatar Dec 15 '22 19:12 flavioislima