Game importing validation bug

[JordanPlayz158]

Describe the bug

When importing a game, whether or not the game is actually imported/the directory being proper. This is only for Epic/Legendary Games

Here is the log but as explained in discord, it doesn't give any meaningful issue because the way game importing is validated is a bit flawed: https://paste.jordanplayz158.xyz/?8bc5a65f02de52c3#ASQZu5iNiE4e4EhLzeZWmaXe8TzcJcTuhnqRyKkUGxqr (here is the start of the discord discussion: https://discord.com/channels/812703221789097985/812703452085223434/977591817220542514)

Here is a video on how to do it: https://dl.jordanplayz158.xyz/2022-05-22%2009-25-11.mp4

Add logs

https://paste.jordanplayz158.xyz/?8bc5a65f02de52c3#ASQZu5iNiE4e4EhLzeZWmaXe8TzcJcTuhnqRyKkUGxqr

Steps to reproduce

1. Go to the download button icon on any game in Epic Games section (must be not imported/installed to have the import option)
2. Go to any path and hit import (as long as it's not the game directory)
3. You will now get a Game Imported notification indicating success but the frontend will tell you it's not installed properly but the backend in the logs will say it imported successfully incorrectly

Watch the video or follow above: https://dl.jordanplayz158.xyz/2022-05-22%2009-25-11.mp4

Expected behavior

Either no notification or Game Import Failure

Screenshots

Even better than a screenshot: https://dl.jordanplayz158.xyz/2022-05-22%2009-25-11.mp4

System Information

• OS [e. g. "Ubuntu"]: Manjaro Linux
• Heroic Version [e. g. 2.1.1]: v2.3.3

Additional information

No response

[krablord]

got same issue trying to import cyberpunk from downloading it before with heroic on different linux distro

[JordanPlayz158]

Issue is still present on Version 2.4.1

[flavioislima]

@JordanPlayz158 what happens if you try importing it directly with Legendary? It gives some error message?

[JordanPlayz158]

This is the output that occurs from incorrectly importing a game (importing a game with the wrong directory)

legendary import Duckbill /mnt/HDD

[Core] INFO: Trying to re-use existing login session...
[Core] INFO: Downloading latest manifest for "Duckbill"
[Core] WARNING: Unable to download manifest from "download.epicgames.com" (status: 403), trying next URL...
[Core] WARNING: Unable to download manifest from "download2.epicgames.com" (status: 403), trying next URL...
[Core] WARNING: Unable to download manifest from "download3.epicgames.com" (status: 403), trying next URL...
[Core] WARNING: Unable to download manifest from "download4.epicgames.com" (status: 403), trying next URL...
[cli] ERROR: No files belonging to Game "Yooka-Laylee and the Impossible Lair" (Duckbill) found in the specified location, please verify that the path is correct.
[cli] INFO: Did you mean "/mnt/HDD/YookaLaylee"?

[JordanPlayz158]

Issue is still present in Heroic "2.12.0 Vegapunk", may take a crack at it, for reference, this is the error when GOG fails to import

(03:21:15) INFO:    [Gog]:              Importing 1544460195: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl --auth-config-path /home/jordan/.var/app/com.heroicgameslauncher.hgl/config/heroic/gog_store/auth.json import /mnt/temp

(03:21:15) INFO:    [Backend]:          Preventing machine to sleep

(03:21:15) INFO:    [Gog]:              Got install info from cache for 1544460195 on windows platform

(03:21:15) INFO:    [Gog]:              Got install info from cache for 1544460195 on windows platform

(03:21:16) ERROR:   [Gog]:              Failed to import 1544460195: SyntaxError: Unexpected end of JSON input

    at JSON.parse (<anonymous>)

    at Module.importGame$2 [as importGame] (/app/bin/heroic/resources/app.asar/build/electron/main.85aacd75.js:42:15749)

    at async /app/bin/heroic/resources/app.asar/build/electron/main.85aacd75.js:220:4638

    at async WebContents.<anonymous> (node:electron/js2c/browser_init:2:88992)

(03:21:16) INFO:    [Backend]:          imported Daymare: 1998