Kennitala

Kennitala copied to clipboard

Package doesn't support the new "Gerviþjóðskrá".

6

Hi, there is a bug/problem here. The package doesn't support the new "gerviþjóðskrá". https://www.skra.is/um-okkur/frettir/frett/2020/10/13/Ny-utgafa-af-gervigognum-thjodskrar/ Those fake kennitala's have got either 14 or 15 in char 7-8. The package assumes 20...

gudmundurm

Support nationalIds for foreigners

7

Foreigners get an "invalid" nationalId once registered, which this library will mark as invalid. It might be better to validate the nationalId, but specify the origin as foreign. So `isPerson()`...

darrikonn

Invalid date is accepted as valid kennitala

2

The `isPerson` validation does not account for invalid dates. I see the current code simply checks that the day is `

MiniGod

Random numbers below 20 are considered valid

4

In #6 you confirmed that the 7-8th digit should start at 20, and fixed the generator. But `isPerson` returns true for the 7-8th numbers below 20. For instance `070222-0000` returns...

MiniGod