Hercules
Hercules copied to clipboard
HerculesWS
2-2 jobs skill rebalance (Part 4 - Bard/Dancer) (2018 Patch/Renewal)
Dependency / Draft reason
This PR depends on #3253, all commits from #3253 are included in this one. The first commit original to this PR is:
Add song groups for Bard/Dancer songs (RE-only)
Leaving as draft since it depends on the other PRs. But this is ready for review, I will just rebase over other PRs and fix some issue CI may find.
Pull Request Prelude
- [x] I have followed proper Hercules code styling.
- [x] I have read and understood the contribution guidelines before making this PR.
- [x] I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.
Changes Proposed
The main purpose of this PR is to introduce the rebalance of Bard/Dancer job skills. This change affects Renewal-only.
On official servers this came along with rebalances of 1st, 2nd jobs and transclass too.
I am not sure whether this could be moved like that, because some skills from transclasses will not play well with the rebalanced ones.
The implementation in this PR is based on kRO and kRO zero patch notes, iRO Wiki, rAthena and divine pride info, along with some in-game testing. I can't say everything is 100% accurate because there were discrepancies between different sources, and I could not test everything in kRO, but should be quite close.
I won't list all the rebalance changes in the PR description, but it may be checked in each commit text. Also, the commits are in the same order as they appear in the references below.
Notes
- Musical Strike and Slinging Arrow has different info about the new Cast Time in each source. (See commit for info). I am using Divine Pride data.
- FrostJoker Cooldown: Sakray notes and Divine Pride says 5s. Main notes and iRO Wiki says 4s. Following 4s.
- Bragi duration 60s -> 180s is from 2019-12-04 and was intentionally left out: https://ro.gnjoy.com/news/notice/View.asp?BBSMode=10001&seq=7191&curpage=1
- Some SP Cost changes is not mentioned in iRO wiki / DP / kRO notes, but it is set in kRO Lua and divine pride.
- I am not 100% sure on how confusion on Rockisveil works
- I am not 100% sure if drum battle ATK bonus really is equip atk like MC_LOUD. but It does come as SP_ATK2.
- From my tests, attack bonus granted by DC_DANCINGLESSON shows in the UI right side of ATK. But in herc it does not. Since this part was not changed in the renewal rebalance, I am unsure whether Mastery was supposed to always show in the UI and we have a long term bug. I won't touch this for now and open an issue for further investigation.
Affected skills
- BA_APPLEIDUN (Song of Lutie)
- BA_ASSASSINCROSS (Impressive Riff)
- BA_DISSONANCE (Unchained Serenade)
- BA_FROSTJOKE (Unbarring Octave)
- BA_MUSICALLESSON (Music Lessons)
- BA_MUSICALSTRIKE (Melody Strike)
- BA_POEMBRAGI (Magic Strings)
- BA_WHISTLE (Perfect Tablature)
- BD_ADAPTATION (Amp)
- BD_DRUMBATTLEFIELD (Battle Theme)
- BD_ENCORE (Encore)
- BD_ETERNALCHAOS (Down Tempo)
- BD_INTOABYSS (Power Chord)
- BD_LULLABY (Lullaby)
- BD_RICHMANKIM (Mental Sensing)
- BD_RINGNIBELUNGEN (Harmonic Lick)
- BD_ROKISWEIL (Classical Pluck)
- BD_SIEGFRIED (Acoustic Rhythm)
- DC_DANCINGLESSON (Dance Lessons)
- DC_DONTFORGETME (Slow Grace)
- DC_FORTUNEKISS (Lady Luck)
- DC_HUMMING (Focus Ballet)
- DC_SERVICEFORYOU (Gypsy's Kiss)
- DC_THROWARROW (Slinging Arrow)
- DC_UGLYDANCE (Hip Shaker)
References:
Issues addressed: Part of #2727
