Hercules
Hercules copied to clipboard
HerculesWS
2-2 jobs skill rebalance (Part 1) (2018 patch/Renewal) and small skill fixes
Dependency
This PR depends on #3223 , all commits from #3223 are included in this one. The first commit original to this PR is:
Rebalance of CR_GRANDCROSS (Grand Cross)
Pull Request Prelude
- [x] I have followed proper Hercules code styling.
- [x] I have read and understood the contribution guidelines before making this PR.
- [x] I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.
Draft Reason
This PR by itself is ready and I don't think there will be further changes, unless someone finds an issue or a review asks for some change.
BUT, the rebalance in main official servers came at once, so I believe the right thing to do is to merge this PR together with the rest of the rebalance (that will be in other PRs).
So I will keep this as draft for now, but feel free to give an early review :)
Changes Proposed
The main purpose of this PR is to introduce the rebalance of part of the 2-2 jobs skills. This change affects Renewal-only.
On official servers this came along with rebalances of 1st, 2nd jobs and transclass too. I am working in additional PRs for the remaining 2-2, including bard/dancer, being in separate PRs in order to keep those PRs in a reasonable size.
The implementation in this PR is based on kRO and kRO zero patch notes, iRO Wiki, rAthena and divine pride info, along with some in-game testing. I can't say everything is 100% accurate because there were discrepancies between different sources, and I could not test everything in kRO, but should be quite close.
I won't list all the rebalance changes in the PR description, but it may be checked in each commit text. Also, the commits are in the same order as they appear in the references below.
Affected jobs/skills
- Crusader
- CR_GRANDCROSS (Grand Cross)
- CR_SHIELDBOOMERANG (Shield Boomerang)
- CR_SPEARQUICKEN (Spear Quicken)
- Alchemist
- AM_DEMONSTRATION (Bomb)
- AM_ACIDTERROR (Acid Terror)
- Rogue
- RG_RAID (Sightless Mind)
- RG_BACKSTAP (Back Stab)
- RG_PLAGIARISM (Intimidate)
References:
Additionally, there were 3 changes not related to the rebalance patch that is being applied in this PR (since it just appeared exactly where I was touching 😅 )
-
(Both) Moved AM_DEMONSTRATION chance of breaking weapon to skill_db.conf
- this simplified the rebalance patch, which gives new chances for renewal
-
(Both) Fixed Rogue's Backstab bow damage
- part of the damage was not being halved because it was in the default 100% ratio, now it properly halves the entire damage
-
(RE) Fix the damage efect of AM_ACIDTERROR
- In renewal, it shows a bundle of 5 hits instead of only 1. (I don't have info for pre-re, so I didn't change it)
Huge thanks to Asheraf and skyleo for helping me with some tests/validations of how it should work.
Issues addressed: Part of #2727
