Hercules
Hercules copied to clipboard
2-1 jobs skill rebalance (2018 patch/Renewal)
Dependency
This PR depends on #3218 , all commits from #3218 are included in this one. The first commit original to this PR is:
add SC_FIRE_EXPANSION_TEAR_GAS_SOB to constants_db
Pull Request Prelude
- [x] I have followed proper Hercules code styling.
- [x] I have read and understood the contribution guidelines before making this PR.
- [x] I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.
Draft Reason
This PR by itself is ready and I don't think there will be further changes, unless someone finds an issue or a review asks for some change.
BUT, the rebalance in main official servers came at once, so I believe the right thing to do is to merge this PR together with the rest of the rebalance (that will be in other PRs).
So I will keep this as draft for now, but feel free to give an early review :)
Changes Proposed
Introduces the rebalance of the 2-1 jobs skills. This change affects Renewal-only.
On official servers this came along with rebalances of 1st, 2nd jobs and transclass too. I am working in additional PRs for the 2-2 and bard/dancer, being in separate PRs in order to keep those PRs in a reasonable size.
The implementation in this PR is based on kRO and kRO zero patch notes, iRO Wiki, rAthena and divine pride info, along with some in-game testing. I can't say everything is 100% accurate because there were discrepancies between different sources, and I could not test everything in kRO, but should be quite close.
I won't list all the changes in the PR description, but it may be checked in each commit text. Also, the commits are in the same order as they appear in the references below.
Affected jobs/skills
- Knight
- Bowling Bash
- Brandish Spear
- Two-Hand Quicken
- Charge Attack
- Blacksmith
- Adrenaline Rush
- Over Thrust
- Assassin
- Sonic Blow
- Venom Splasher
- Wizard
- Lord of Vermillsion
- Meteor Storm
- Storm Gust
- Jupitel Thunder
- Earth Spike
- Heaven's Drive
- Priest
- Magnus Exorcismus
- Mace Mastery
- Suffragium
- Imposition Manus
- Hunter
- Land Mine
- Claymore Trap
- Blast Mine
- Blitz Beat
Also, on a side note, I fixed a missing constant in db/constants.conf
References:
Issues addressed: Part of #2727