Hercules
Hercules copied to clipboard
Map Property Adjustment.
Pull Request Prelude
- [x] I have followed proper Hercules code styling.
- [x] I have read and understood the contribution guidelines before making this PR.
- [x] I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.
Changes Proposed
- Dropped clif_maptypeproperty2() and merged it with clif_map_property().
- Renamed packet_maptypeproperty2 to packet_maptypeproperty and added support for 0x99b(ZC_MAPPROPERTY_R2).
- clif_map_property_mapall() now redirects its clif_send() job to clif_map_property() which has dummy bl.
Thanks to @Kenpachi2k13
Issues addressed: #2892
i know in all emulators map property partially broken, but even if this packets have similar names, they different. i not sure is it good idea to drop one of them 0x199 change only one property. 0x99b change all properties for given type at same time.
look like exists atleast some flags what can change only 0x199
@MrKeiKun @4144 @MishimaHaruna what's the status on this, can it be merged?