Hercules
Hercules copied to clipboard
Expand the use of the boss flag
Is your feature request related to a problem? Please describe. the md->state.boss flag currently only works when mvp or boss is spawned by script
The command @monster does not use the flag, it should be used when a mvp or boss monster is generated by the command, because the flag is exactly for that, to differentiate MVP and Boss from normal monsters.
Describe the solution you'd like I think a check should be done when the @monster command is used, if the monster is mvp or boss apply the flag
This feature was implemented in the commit https://github.com/HerculesWS/Hercules/commit/aa8466c0b83f12599305032df5c86b8ec59ae444
The boss state should be appliable when using @monster
and monster()
script command, too.
the reason why it was separate boss_monster
and monster
spawn right now is because of convex mirror
prontera,155,185,0,0 monster PORING 1002,1,5000,5000
prontera,155,185,0,0 boss_monster PORING 1002,1,5000,5000
I just tested @item 12214
and try it, it actually shows the location of Poring, even though it isn't exactly an MVP
can anyone with Aegis or have tested on official server can confirm this ? -> beat the endless tower, summon out the Nacht Sieger MVP, and use convex mirror does the convex mirror show the MVP location ? right now it doesn't show the location of instanced monster in hercules because like this issue describe
we separated the md->state.boss and MD_BOSS flag
md->state.boss -> different by script spawn by monster
and boss_monster
md->status.mode & MD_BOSS -> boss flag defined from mob_db.conf
actually there is another Class_Normal, Class_MVP, Class_Boss, Class_Guardian that Asheraf claimed it has in Aegis https://github.com/HerculesWS/Hercules/pull/2008#issuecomment-378660444 and rathena partially implemented them https://github.com/HerculesWS/Hercules/pull/2821#issuecomment-703289592
boss flag also sent to client. not sure how it using this. probably it affect hp bar