Hercules icon indicating copy to clipboard operation
Hercules copied to clipboard

Party buffs on dead characters

Open kyeme opened this issue 8 years ago • 8 comments

In official even if your character dies, party buff still applies, except toggle required buff. Example: Angelus, Gloria etc.

Official: ss1

Hercules: ss2

kyeme avatar Mar 22 '16 14:03 kyeme

Aegis behavior looks buggy and this doesn't affect anything as far as I know, just a visual thing.

AnisotropicDefixation avatar Mar 23 '16 03:03 AnisotropicDefixation

This is not just a visual effect only. They can still receive buffs from their Priest/High Priest even if they are dead and it is vital for the Priest because he/she didnt have to recast that buff again(Gloria/Angelus) as they have it already even before they got resurrected.

kyeme avatar Mar 23 '16 12:03 kyeme

@AnisotropicDefixation its not buggy at all.. it is how aegis coded there skill system..the skill display code is separated with the code skill execution, unlike in athena they are in the same line or function...in which the filter for valid target is comes first nullifying the succeeding code...

in Aegis trigger skill -> skill animation effect -> skill computation -> apply all after effects

in Athena trigger skills -> skill computation -> skill animation effect -> apply all after effects

but take note this is not the same with other skills specially those having this flag(SKFLAG_DISTINCT_DAMAGE_FORMULA)

malufett avatar Mar 23 '16 17:03 malufett

But this doesn't mean that dead characters are actually getting buffs, this is just a visual thing, right?

AnisotropicDefixation avatar Mar 24 '16 09:03 AnisotropicDefixation

@malufett Not sure if it's generally like that. There are those skills that display animation when they fail and there are skills that don't display animation when they fail. There are even skills that on certain error displays the animation and on other error they don't, e.g. if you cast Waterball on a target that has 100% resist to it, it will display the "MISS" animation, but if you cast Waterball on a target that has 101% or more resist to it, the animation will not show.

Also, Aegis has to compute the skill before the animation too because e.g. you first need to know how much damage it does because you can send the skill_damage packet to the client.

It's probably more that there are 3 independent checks for skills. One at castbegin, one at castend and another one after showing the skill animation effect.

Also according to @kyeme, you actually get the buff, even if dead. I assume the "isdead" check only happens at cast begin against the target and when applying damage. A nodamage skill that is not targetted will still just work.

Playtester avatar Mar 24 '16 13:03 Playtester

@Playtester yeah..that's why I added a note after...but most of them are post renewal skills and non damage type...

malufett avatar Mar 24 '16 17:03 malufett

@Kenpachi2k13

Jedzkie avatar Jun 25 '20 22:06 Jedzkie

After testing on Aegis I can confirm this. Dead party member do get the buff. I only tested Gloria for now. I'll check other group buffs and ground skills like Bard/Dancer songs, too.

Kenpachi2k13 avatar Jul 01 '20 10:07 Kenpachi2k13