FluxCP
FluxCP copied to clipboard
Fix searching items by itemtype
1. Cannot search item with itemtype is Healing
File: modules/item/index.php
With Healing items $itemType value is 0.
Is mean if ($itemType && $itemType !== '-1') allways false with Healing items selected.
We can use if ($itemType > -1). But I keep same style with checker $equipLocs line 103
@@ -55,7 +55,7 @@
$bind[] = $itemName;
}
- if ($itemType && $itemType !== '-1') {
+ if ($itemType !== false && $itemType !== '-1') {
if (count($itemTypeSplit = explode('-', $itemType)) == 2) {
2. Cannot search item with itemtype is subtype
File: modules/item/index.php
Currently, FluxCP check view_sprite for subtype is incorrect.
@@ -72,10 +72,10 @@
if (count($itemTypeSplit) == 2 && is_numeric($itemType2) && (floatval($itemType2) == intval($itemType2))) {
$itemTypes2 = Flux::config('ItemTypes2')->toArray();
if (array_key_exists($itemType, $itemTypes2) && array_key_exists($itemType2, $itemTypes2[$itemType]) && $itemTypes2[$itemType][$itemType2]) {
- $sqlpartial .= "AND view_sprite = ? ";
+ $sqlpartial .= "AND subtype = ? ";
$bind[] = $itemType2;
} else {
- $sqlpartial .= 'AND view_sprite IS NULL ';
+ $sqlpartial .= 'AND subtype IS NULL ';
}
}
This PR looks correct and can be merged to improve the project.