Robin De Schepper

Results 186 comments of Robin De Schepper

No, but I like that JSON:API provides a full "HTTP-URL-compliant" spec to query REST API's including nested relationships and field selects! And in general I enjoy adhering to standards because...

Sounds good! Is the PR/release workflow documented somewhere? I'll get started on this 😊

Just one thing, I misinterpreted the query parameter section, and as long as a query parameter contains at least one non a-z character it's a valid implementation query parameter: >A...

Ok, I'll PR them separately but targetting a new feature branch, so that they land on `master` as 1 breaking change!

Yes, I'm working on it on the `json-api` branch, and have an open PR https://github.com/ppetzold/nestjs-paginate/pull/883 that addresses some of the points here already.

@vsamofal I found that splitting this into 4 different PR's would contain too much duplicated code :) This was just some shuffling around either way, and I will submit the...

Converting to draft because I think I broke multi-filters (I wasn't aware of this spec and it was untested in the decorator spec).re Update: false alarm, it was already tested...

I'm semi-sceptical about leaking all the available column names in `meta.search.fields` ... Perhaps it's sufficient to repeat only the given and valid `fields` like we do for `filters`, and we...

@FrancYescO certainly correct: we are planning to introduce the switch to JSON:API as a new breaking change and major version.

Well the example you picked is an undocumented feature that adds no advantages to the end user, but would add complexity to maintain, test and document; so it may not...