Alex Xu

v2: return error instead of panicking when sockstat has unexpected format

v3: fix indentation

> we can also have a mapping for the metric names to make them follow our naming best practices.. according to the comment, ``` // Previously these metric names were...

> Currently we explicitly require collectors to not maintain such mapping as in https://github.com/prometheus/node_exporter/blob/master/CONTRIBUTING.md#collector-implementation-guidelines This policy says "The metrics should not get transformed"; in this PR, I never suggested changing...

fwiw, it can be done "manually" by simply `cat archive.r* | bsdtar xf -`, or of course `cat archive.r* > archive2.rar && bsdtar xf archive2.rar`. i think this works for...

er... I deleted the build logs, but I can scrounge them back up. I also added a workaround to force the tests to run one at a time (-j1) instead...

I'll try again without using Xvfb and see what happens.

I do not use gpg agent, portage doesn't run one, and it runs as a separate user anyways.

example output: ``` 10/16 Testing: bad_content_id 10/16 Test: bad_content_id Command: "/tmp/portage/mail-client/astroid-9999/work/astroid-9999_build/tests/run_test.sh" "/tmp/portage/mail-client/astroid-9999/work/astroid-9999" "/tmp/portage/mail-client/astroid-9999/work/astroid-9999_build" "test_bad_content_id" Directory: /tmp/portage/mail-client/astroid-9999/work/astroid-9999_build/tests "bad_content_id" start time: Jul 05 20:25 EDT Output: ---------------------------------------------------------- Source dir: /tmp/portage/mail-client/astroid-9999/work/astroid-9999 Build dir:...

fwiw, my initial comment was a bit strong. it's ok to require X in tests, but it should be actually necessary, i.e. you are actually testing the GUI. and even...