helix-ui icon indicating copy to clipboard operation
helix-ui copied to clipboard

Don't show Tab focus outlines or selected text

Open TheNando opened this issue 7 years ago • 4 comments

Other tab implementations I've seen hide tab focus outlines and don't allow selecting text.

tab-select

This can be achieved by setting outline: none and user-select: none respectively.

TheNando avatar Mar 06 '18 17:03 TheNando

Thanks for reporting this. We're in the process of finalizing our focus states and this will be updated accordingly, in the near future.

CITguy avatar Mar 06 '18 17:03 CITguy

Also, to note, user-select: none; isn't guaranteed to prevent selection.

CITguy avatar Mar 06 '18 23:03 CITguy

Unfortunately, we can't remove the outline on focus due to accessibility requirements and browsers haven't implemented the :focus-visible pseudo-selector to allow us to turn off the outline only for mouse interaction. We're looking into options (differing styles or the focus-visible polyfill).

CITguy avatar May 21 '18 18:05 CITguy

For reference:

  • https://developer.paciellogroup.com/blog/2018/03/focus-visible-and-backwards-compatibility/
  • https://drafts.csswg.org/selectors-4/#the-focus-visible-pseudo
  • https://caniuse.com/#feat=css-focus-visible

CITguy avatar May 21 '18 19:05 CITguy