Helium314

Results 1058 comments of Helium314

Should be fine! Note that I decided to wait for a while before doing something on SCEE again, so that I don't run into more trouble when more files move...

> Can we add the https://github.com/streetcomplete/StreetComplete/issues/5664? Sure, would be fine. Note that I decided to pause development for a while, as I had some issues merging upstream and want to...

> I'm presuming the "app/src/main/java/" path in the links should be "app/src/androidMain/kotlin/" now? It's currently split into app/src/androidMain/ and app/src/commonMain/. There's certainly a lot that will move from android to...

> I would like to be able to opt-in into HeliBoard calling KDE Connect's [ClipboardFloatingActivity](https://invent.kde.org/network/kdeconnect-android/-/blob/master/src/org/kde/kdeconnect/Plugins/ClipboardPlugin/ClipboardFloatingActivity.java) whenever the clipboard is changed, and thus removing the friction from clipboard sync. This should...

I'll go through this log in the next few days, but note that SCEE has some code changes that might introduce this bug. So maybe this doesn't concern SC.

What I read from the log (in order): 1. quests from a download are created while the quest form is open 2. the quest is solved 3. the quests from...

> hmm, does that explain why it also persists? I.e. the quest wont go away even after solving it multiple times. I think so. The quest is not in the...

I [added a test](https://github.com/streetcomplete/StreetComplete/blob/Helium314-reproduce-5545/app/src/test/java/de/westnordost/streetcomplete/data/osm/osmquests/OsmQuestControllerTest.kt#L368-L426) that reproduces what I think is happening. In the test, first `onReplacedForBBox` is called (what a download would do), then `onUpdated` is called (what solving a...

Without proper investigation: maybe the solution could be similar to [`MapDataWithEditsSource.updatesWhileReplacingBBox`](https://github.com/streetcomplete/StreetComplete/blob/master/app/src/main/java/de/westnordost/streetcomplete/data/osm/edits/MapDataWithEditsSource.kt#L72)

> I would like to avoid a solution like `updatesWhileReplacingBBox` because it is somewhat complex. Couldn't more aggressive `synchronized` help? Yes, that could definitely solve the issue. The drawback would...