Helium314
Helium314
1. my fault, I had put the wrong hash in `gradle-wrapper.properties` 2. why do you create another keyboard? 3. I never worked with sessions for the dictionaries. I guess this...
> What's the alternative? I haven't properly looked through the code yet, but my idea way getting some kind of offset from the popup keyboard (maybe whether popups are displayed...
> Is it a bug that adding/removing/replacing a dictionary requires an app restart? That would be a bug. > Please let me know when it's ready, or if I can...
> Thanks. How do I get a Dictionary to pass to it? You can use `DictionaryInfoUtils.getCachedDictsForLocale` and then create a `ReadOnlyBinaryDictionary` from the file. See `DictionaryFactory.checkAndAddDictionaryToListNewType` for an example. If...
> Thanks. Done. I refactored DictionaryFactory.checkAndAddDictionaryToListNewType in order to reuse the logic. It's less efficient now in the case of multiple dictionaries for a locale-type combination, but that's rare, right?...
> Am I guarantied that this has been done by the time the emoji keyboard is shown, or do I have to trigger it? How? Well, the file is extracted...
> You mean that if we add an emoji dictionary to assets, and the user doesn't add it to their list of dictionaries At the moment the user doesn't have...
> Can we deal with emoji dicts in assets in a separate PR? Sure! (I'm pretty sure I already replied to this, but I don't see my comment. That's already...
I'd say the descriptions look mostly fine, but the text is clearly too large. Text size should be closer to what we see in clipboard view. It's not just style,...
> This is still a (rare) problem. An example: if I long-press judge, then man judge, the popup will show judge. If I long-press a second time, the popup is...