Helium314

> I think all calls for `OsmQuestSource.getAllVisibleInBBox` come from `VisibleQuestSource` anyway right? So, having the cache there seems to be more impactful than having it in `OsmQuestSource`. If caching is...

I just noticed that deleted quests in `OsmQuestSource.onUpdated` are provided as `Collection`. So for efficiently removing deleted quests from cache (e.g. on anwering or hiding a quest) `Cache` is actually...

I noticed the overall usefulness of the cache for `OsmQuestController.getAllVisibleInBBox` may be significantly less than I thought due to other things happening. `VisibleQuestsSource.getAllVisible` adds some time for getting notes and...

The problem here is that while `OsmQuestController.getAllVisibleInBBox` is much faster (~10 ms instead of several 100), there are more things that take some time. This is getting all notes in...

> Better defer that until the implementation had progressed (see my comment on the draft PR). In particular, I spotted some other things that my slow it down but thought...

It's 7 tables. There is no separate table for node geometries, but ways and relations use 2 tables each. The reason why I tried to have one cache is because...

> You say that a by-bbox-cache that holds everything would be faster. Why do you think that? Can you point to where I said that? Since I didn't even know...

> Sorry, I kind of misread "The reason why I tried to have one cache is because [...] the main reasons for creating the cache are essentially having a faster...

> Better defer that until the implementation had progressed (see my comment on the draft PR). In particular, I spotted some other things that my slow it down but thought...

> I would be curious to know if this improves things. `updatePins()` improved by ~70 ms / 20%, and I think creating quest pins also improved by maybe 10 ms...