Helium314

> it would litter ClipboardHistoryManager, If you think ClipboardHistoryManager is going to grow too much, you could have the view creation happen in a utility file. The re-use of the...

Seriously, those parts of the contribution guidelines have been there since OpenBoard times. And they don't exist just because someone likes writing guidelines. For me the whole process is also...

I adjusted the PR to use the (now renamed) `setInlineSuggestionsView`, and create the view in `ClipboardHistoryManager`. Behavior is same, or very close to, except for: * always showing the dismiss...

It will not appear if the clip is more than 3 min old. But it will not disappear on its own if you just wait and stare at the keyboard...

I hope the implementation is ok for you. I tried to keep behavior close to your version when moving most of the stuff into that one view. (Will also work...

Do you know whether original OpenBoard has the same issue?

I just tried on a Galaxy A3 2017 on LineageOS 17.1. Both disabling and enabling the _Show virtual keyboard_ setting works as expected (on HeliBoard and on OpenBoard). Could be...

I would very much expect that this code exists for a reason (given the text). Further this is a change I would expect to cause issues other apps (at least...

I finally had a look at Logseq (btw I think this is one of the most horribly slow apps I ever used). There is indeed _nothing to delete before the...

This is changing something that has been there for [more than 10 years](https://github.com/LineageOS/android_packages_inputmethods_LatinIME/blob/lineage-21.0/tools/make-keyboard-text/res/values-ro/donottranslate-more-keys.xml), and in my opinion should be handled more carefully since users quite possibly got used to it....