Helium314
Helium314
I agree that passing `mapDataApi` and the local element is not good. How about: * don't pass any element * remove `element` from `ElementEditAction.createUpdates` and use `mapDataRepository.get` * have a...
> I wonder if there was a specific reason why I did not do it like this from the start. I did't find any reason in other actions, or in...
> So, if there was no reason, then I am all for it. Makes it simpler. I did not (yet) change this. If you're ok with the way it is...
> I will use/test it for a while And I did, including some logging. * Normal upload without conflicts: works as expected * Conflict when uploading a SplitWayAction (way split...
I didn't really notice the difference... though I did some logging, and time for uploading was reduced by somthing like 80-100 ms on average. But I usually have auto-upload off,...
> Would attempting to capture logcat output (after the bug shows itself) help? > Any debug I might add in my fork that might help? You could trace what happens...
It might also be good to remove the `opening_hours:signed` check date when removing `opening_hours:signed`.
I would like to add that the issue is not limited to to currently shown notes. After a not shown note is modified in a "bad" way, by syncthing in...
I tried detecting such move / re-creation and trigger a reload by QOwnNotes. Detection works reliable (using inotifywait), but haven't found a way to reliably trigger a reload. Even overwriting...
Thanks! I tried modifying https://github.com/pbek/QOwnNotes/blob/main/docs/scripting/examples/on-note-opened.qml ``` function noteOpenedHook(note) { script.log(note.fullNoteFilePath); mainWindow.buildNotesIndexAndLoadNoteDirectoryList(false, true); } ``` While this seems to work, now every note switch collapses the note folders (I'm using the...