SCEE icon indicating copy to clipboard operation
SCEE copied to clipboard

area=yes building:part=yes should be described as Building part, not as an Area

Open matkoniecz opened this issue 4 months ago • 5 comments

It is about message below the quest title, for example facade material quest.

May be worth fixing in SC directly, maybe should be fixed in iD presets, maybe osm features library.

But right now it affects SCEE only

I would try to fix it myself but I am without access to laptop right now

See say components of Biserica Mănăstirii "Stavropoleos"

I have screenshot but adding it via mobile seems broken in one way or another. If useful I can add it soon.

Versions affected

61.1

matkoniecz avatar Jul 18 '25 03:07 matkoniecz

Maybe something could be done in FeatureDictionary.getFeature. Currently it returns the first feature if there are multiple matches. Though there is already some sorting happening in osmfeatures. Ideally the issue would be fixed there.

Helium314 avatar Jul 25 '25 08:07 Helium314

looking at this code, seemingly building_part should have priority over area

https://github.com/openstreetmap/id-tagging-schema/blob/3f724af32a10301c11928a08afa0b4bd15db7af9/data/presets/area.json

https://github.com/openstreetmap/id-tagging-schema/blob/3f724af32a10301c11928a08afa0b4bd15db7af9/data/presets/building_part.json

matkoniecz avatar Jul 25 '25 08:07 matkoniecz

Right, so maybe things go wrong somewhere else...

Helium314 avatar Jul 25 '25 09:07 Helium314

Or code is buggy in way or another (like flipped ordering, or match score compare always returning 0 due to float fun or something). I guess that ideal next step would be to set breakpoints and see where data gets broken.

matkoniecz avatar Jul 25 '25 09:07 matkoniecz

I would try to fix it myself but I am without access to laptop right now

Hopefully that might have happened by now? 😸

mnalis avatar Aug 19 '25 03:08 mnalis