Introduce `payment:credit|debit_card:signed` = `no`

[vfosnar]

trafficstars

Use case

I usually have two presets, one for outdoor and one more detailed for mapping indoor. Having an option to mark place as "not having a visa sign and someone has to go indoor to check it" would save me quite a lot of time figuring out what places I've checked from the outside. I guess there is little added value to OSM itself by adding this tag but it could be handy to mappers.

Proposed Solution

Add option to respond "unknoen - not signed" to the payment methods quest. Then have the option to show all / show only those without ...signed = no for each preset

I understand this is a niche use but I'm willing to implement it if we figure out the UX and it won't take me too much time.

[Helium314]

There are 0 uses for payment:credit_cards:signed and payment:debit_cards:signed, and I don't think SCEE is the right place to introduce new tags. Or is :signed acceptable to add anywhere? It could make sense to "allow" it.

[vfosnar]

I think this would make a valid exception anyways because the only benefit is for OTG mappers.

[mnalis]

Having an option to mark place as "not having a visa sign and someone has to go indoor to check it" would save me quite a lot of time figuring out what places I've checked from the outside

Perhaps a can't say / create custom quest (if enabled in settings) would be acceptable alternative to make it easier for mapper to keep track of such things which needs more detailed survey, while also being more versatile (e.g. one might need to enter the restaurant and look at the menu to answer diet:vegan and similar quests too; and the same issues applies equally to diet:vegan:signed=no, smoking:signed=no, religion:signed=no etc.).

Or is :signed acceptable to add anywhere? It could make sense to "allow" it.

Well, it might be acceptable according to the wiki, as it is intended as a suffix for multiple keys.

Even so, I'm not too thrilled about the idea - those tags are not being used currently at all, applying to single quest is very narrow, increases complexity[^1] and so far I've not seen anyone else adding their 👍 on the issue to indicate they too would benefit from it being implemented.

That being said, if alternative approach of using Custom Quest is not good enough, I'm not against you writing this, provided it can be done in clean and reusable way (e.g. have it apply automatically on all quests having default_disabled_msg_go_inside, default_disabled_msg_seasonal , ordefault_disabled_msg_go_inside_regional_warning without having to mess with code in each quest separately would be ideal).

But if you have free time @vfosnar, finishing the ref:vatin PR https://github.com/Helium314/SCEE/pull/669 is probably better use of time - it's much easier and would benefit at least one more person (myself 😺 ) [^2]

[^1]: it's not just about writing the extension: it needs to maintained too, potential merge conflicts solved on each version upgrade etc.

[^2]: of course I understand if you're no longer interested in that one at all, so please don't take it as some kind of requirement! Also, I don't care about IČO Quest part of that PR, so it can be dropped if you don't need that either, to reduce complexity even further.