SCEE icon indicating copy to clipboard operation
SCEE copied to clipboard

`sac_scale` should also be asked for highway=footway and others

Open dbdean opened this issue 7 months ago • 2 comments

How to Reproduce

Run SCEE in an area with hiking tracks marked as highway=footway and dirt-like surface. Like here: https://www.openstreetmap.org/#map=16/-27.53646/153.03758

If you have the sac_scale quest open it will only show up for highway=path

Expected Behavior

Any dirt trails that don't currently have a sac_scale should ask for them. This should include highway=footway, and others like cycleway, bridleway, service, track, unclassified etc as long as they have a dirt-like surface and don't have foot=no.

The wiki makes it clear that it isn't just highway=path at https://wiki.openstreetmap.org/wiki/Key:sac_scale#How_to_map.

Does it happen in normal StreetComplete?

The sac_scale quest is not in normal SC.

Versions affected

SCEE v61.0 on Android 15

dbdean avatar May 16 '25 02:05 dbdean

Any dirt trails that don't currently have a sac_scale should ask for them. This should include highway=footway, and others like cycleway, bridleway, service, track, unclassified etc as long as they have a dirt-like surface and don't have foot=no.

Hmm, I'm not sure... Maybe for fully-unpaved footways, but even there, only 0.08% have sac_scale (which is two orders of magnitude less than for highway=path !). Other are even more dubious IMHO.

BTW wiki change that suggests tagging sac_scale on service and unclassified roads (which I find quite strange) was added by user justifying it by saying it's "hopefully uncontroversial" (without backing it up as far as I can see) and nothing like that was present in original approved proposal; so I'd be somewhat wary of that.

See https://github.com/Helium314/SCEE/pull/557#issuecomment-2207025185 during implementation where filter was found too weak, creating much too many quests, where none exist.

It would however be nice if the quest had regular elementFilter editor like most other quests which would allow users to set it the way they want it, but it seems it has something different. I don't know how much work it is to also add elementFilter editor in combination with that 🤷

The wiki makes it clear that it isn't just highway=path at https://wiki.openstreetmap.org/wiki/Key:sac_scale#How_to_map.

It does say that those are for "Any other unpaved way when appropriate", which is a bad choice for a quest filter. For sac_scale Overlay (which was also suggested but never implemented), it might be fine to include them (esp. if "uncolored if undefined") IMHO.

mnalis avatar May 16 '25 19:05 mnalis

@mnalis the quest already has a normal element Filter, but the filter is not automatically open for editing because a. for that the quest would need to be a OsmFilterQuestType (which does not allow filtering by relations) and b. even if it were, there already are more specific quest settings that would override the OsmFilterQuestType default.

You can check how it's done for opening hours, which is a similar mostly-element-filter quest type that has element selection and some other setting added.

Helium314 avatar May 17 '25 18:05 Helium314