SCEE icon indicating copy to clipboard operation
SCEE copied to clipboard

more / unique icons for custom quests depending on tags

Open joshinils opened this issue 7 months ago • 5 comments

I know this could require a bit of handywork — provide the necessary data, like a lookup table and/or more icons.

But it'd be nice to have a tree shown, or a street_lamp icon instead of the generic question mark on a blue background for all custom quests.

The simplest change could be; depending on the keys to be added, sort them, hash them, and based on that, pick a different hue for the background of the question mark?

In case they are to be more distinguishable, maybe use a different shape for the custom quests? i.e. normal=circle, custom=hexagon?

joshinils avatar Apr 03 '25 05:04 joshinils

But it'd be nice to have a tree shown, or a street_lamp icon instead of the generic question mark on a blue background for all custom quests.

While it would look nice, it sounds awfully complex to implement with custom images (for starters, the format would likely no longer be CSV, or would have to have base64-encoded images or something). It would also be quite hard for CSV producers, so not likely to be used very much.

Perhaps if CSV format was extended so addNode might be preceded by e.g. addIcon which references one of existing SCEE image resources used by other quest might be simpler, but then it would be somewhat confusing (i.e. is that lamp icon original lamp quest, or some custom quest for lamp?)

I wonder how many users would take the effort use that functionality in their CSV files, though. Voting: Please add a 🚀 reaction to this post if you use Custom Quests and would go to extra trouble to specify such icon in your .csv files.

The simplest change could be; depending on the keys to be added, sort them, hash them, and based on that, pick a different hue for the background of the question mark?

While that one might be more easily doable, it would IMHO be more confusing than useful, unless the icon for Custom Quest was changed completely first - we already reuse same "question mark" icon for Notes Quest, Osmose Quest, Custom Quest (and maybe more?) and they only differ in hue...

mnalis avatar Apr 03 '25 09:04 mnalis

The first major issue is even way before how to encode the icons or whether to just change background color. Currently each quest type (or more precisely EditType) has an id that refers to an icon packaged with the app. So either there needs to be a parallel system to get quest icons, or the current system has to be changed considerably. Both would require a lot of work, and very likely even more work to handle conflicts when merging changes in SC.

Perhaps if CSV format was extended so addNode might be preceded by e.g. addIcon which references one of existing SCEE image resources

This would avoid one of the problems above, but we'd still need an icon per quest instead of per quest type.

Helium314 avatar Apr 03 '25 13:04 Helium314

This would avoid one of the problems above, but we'd still need an icon per quest instead of per quest type.

I could supply an ID for each custom quest, so my script generates one by looking at the tags for each new node.

This ID could then be used to split the single custom quest-type into multiple quest-types, no?

I thought about this because every tree, lamp, bollard, gate, street_cabinet, etc. look the same here as each other custom quest: Screenshot_20250404_082136_SCEE.png

joshinils avatar Apr 04 '25 06:04 joshinils

we already reuse same "question mark" icon for Notes Quest, Osmose Quest, Custom Quest (and maybe more?) and they only differ in hue...

I think that should be solved differently anyway, i.e. give Notes their own icon.

joshinils avatar Apr 04 '25 06:04 joshinils

This ID could then be used to split the single custom quest-type into multiple quest-types, no?

Technically yes, but it would require a pre-defined number of custom quest types, each with different icon, and all of them in the quest selection list (which actually displays quest types, not individual quests).

Hm, and I'm currently not even sure whether the IDs are stable across versions. Could be that they change when upgrading (when new strings, icons, etc are added) Edit: that's not an issue, we can derive IDs from the icon name.

Helium314 avatar Apr 04 '25 19:04 Helium314