Don't ask for type of service building if disused service is tagged on it

[dbdean]

How to Reproduce Have a building=service with disused:power=substation on it (like https://www.openstreetmap.org/way/1327381560), it will show up as a quest asking what sort of service building it is.

Expected Behavior It shouldn't ask what sort of service building something is if it is marked as a disused service (or at least not for a suitable resurvey time period). It may also be useful to have a way of selecting that it is a disused service building in the quest too, maybe?

Does it happen in normal StreetComplete? I don't think this quest is in normal SC.

Versions affected I'm using v60.3 on Android 15

[mnalis]

It shouldn't ask what sort of service building something is if it is marked as a disused service

Makes sense to me... We don't ask for power=*, so we shouldn't ask at disused:power=* either (or other tags e.g. utility=* -> disused:utility=* etc). But there are other lifecycle prefixes which might exist, e.g. abandoned:power=*, should we skip them too? Would someone research which ones are popular? The list could become quite long otherwise...

It may also be useful to have a way of selecting that it is a disused service building in the quest too, maybe?

Hmmmm, you mean similarly like in "it's demolished (traces visible)" answer?

That wouldn't work, as the quest is asked on building=service but only if it misses power=*, utility=* etc. tags already marking what is is being used for. So if the quest did pop up, there is nothing to mark it as e.g. "disused:power=substation", as none of those tags are present on the element, so we don't know what is "disused".

[Helium314]

Makes sense to me... We don't ask for power=*, so we shouldn't ask at disused:power=* either (or other tags e.g. utility=* -> disused:utility=* etc). But there are other lifecycle prefixes which might exist, e.g. abandoned:power=*, should we skip them too? Would someone research which ones are popular? The list could become quite long otherwise...

I think we only need to cover things that would reasonably apply to the service part, but not to the building part, because e.g. demolished:building=service doesn't trigger the quest anyway.

That wouldn't work, as the quest is asked on building=service but only if it misses power=*, utility=* etc. tags already marking what is is being used for. So if the quest did pop up, there is nothing to mark it as e.g. "disused:power=substation", as none of those tags are present on the element, so we don't know what is "disused".

Answers in that menu can be added based on tags, but then obviously it could be added only for the operator quest as the type must already be determined.

[dbdean]

That wouldn't work, as the quest is asked on building=service but only if it misses power=*, utility=* etc. tags already marking what is is being used for. So if the quest did pop up, there is nothing to mark it as e.g. "disused:power=substation", as none of those tags are present on the element, so we don't know what is "disused".

You could do something like disused:service=yes, or something similar.

[dbdean]

In the tag info combinations page, there is no lifecycle prefix use shown in combination with building=service (but it doesn't show combinations with less than 1000 objects, by the look of it): https://taginfo.openstreetmap.org/tags/building=service#combinations.

My thoughts at least would be that construction:*, disused:*, abandoned:* and was:* prefixes combined with the various service things could easily be combined with building=service to indicate that there was or will be a service of some sort installed here, but it isn't here right now (and so shouldn't be asked in this quest). Most of the other lifecycle tags would probably indicate that the building was removed or changed such that it isn't really a service building anymore.

[mnalis]

In the tag info combinations page, there is no lifecycle prefix use shown in combination with building=service (but it doesn't show combinations with less than 1000 objects

Yeah, there are about hundred or few worldwide (mostly disused/abandoned:power) currently tagged on the same OSM element: https://overpass-turbo.eu/s/21Ur

Answers in that menu can be added based on tags, but then obviously it could be added only for the operator quest as the type must already be determined.

So one would first answer that it is e.g. "power substation" (regardless if it is functioning one or not), and then in subsequent operator quest they could answer in submenu that "it is abandoned" (or "disused"? both would probably be an overkill?) which would change the tagging.

That would be quite fine, but the problem is if the user doesn't solve the subsequent question (maybe they don't even have it enabled)? That would leave the building tagged as functional power substation, when it clearly is not. Still, it could be about the best we can do (perhaps add that info button explaining?) 🤷

You could do something like disused:service=yes, or something similar.

Yeah, adding such answer would deal with the "spam" (i.e. make the quest go away for everyone on abandoned service buildings), but then, it fails to record the useful information what is actually abandoned (which is kinda the point of that quest - e.g. abandoned ventilation shaft is quite different thing from abandoned power plant...)

[dbdean]

@mnalis, you could allow just an "it is disused" as a answer to the current quest. Then have another quest (or a variant of the current quest) that asks "What type of disused service was here?". That way it gets tagged as a disused service first, before it gets tagged with whatever service it was.

But for this issue, either way, it shouldn't ask for a service type if a disused service is already tagged.