SCEE icon indicating copy to clipboard operation
SCEE copied to clipboard

Option to see comments on a note

Open HafizBeyy opened this issue 10 months ago • 10 comments

I like solving notes. So i switched to SCEE and also for a few other reasons. I know comments on a note cannot be deleted but it would be good to see what i commented at from the recent changes tab. Apart from this, should i also open this issue on main StreetComplete repository?

HafizBeyy avatar Feb 25 '25 16:02 HafizBeyy

I know comments on a note cannot be deleted

Yes, once uploaded to OSM servers, Notes (and their comments) cannot be deleted. However, if you disable option Settings / Upload answers automatically; they you can "delete" (actually "undo") that note comment before it has been uploaded (i.e. while it still exists only locally on your phone). You use Undo button (at the lower left part of the map) for that. Of course, you should then remember to upload all your answers manually (for example, when you get back home from mapping).

it would be good to see what i commented at from the recent changes tab

I'm not sure what you mean here by "recent changes tab". If you mean Undo button in SCEE (the one at the lower left part of the map), then the comments you left on the notes are already displayed there (icon is red circle with white question mark inside). Does it not show for you?

Apart from this, should i also open this issue on main StreetComplete repository?

Let's first see (in this already opened issue) if what you want already exists...

If it does, then everything is solved. If it doesn't, generally the procedure is to first try asking for feature in upstream StreetComplete, and only if it is refused there, to ask in SCEE (That is because SCEE "inherits" all the goodies from the StreetComplete, and the less separate features it needs to maintain, the better it is for long term maintainability of the SCEE).

mnalis avatar Feb 25 '25 17:02 mnalis

Undo button in SCEE

yeah that one. i dont mean to just display the icon. see this picture: Screenshot_20250225-211624_SCEE.png

i edited tags of a poi. and i can see what i changed with the undo button. i also want to see what i commented when i click on the exclamation mark icon just as with tagging.

HafizBeyy avatar Feb 25 '25 18:02 HafizBeyy

i also want to see what i commented when i click on the exclamation mark icon just as with tagging.

And don't you see it? double-exclamation-mark icon is used when you commented and closed a note. When I click on it in Undo window, I can see details (i.e. commented text in the case of the note), just as when I click on any other quest.

e.g.

Image

Does something different happen to you?

mnalis avatar Feb 25 '25 23:02 mnalis

Screenshot_20250226-110310_SCEE.png

no not all. yesterday i closed some notes and this problem first started tha time

HafizBeyy avatar Feb 26 '25 08:02 HafizBeyy

i've automatic upload turned on btw. i dont want to undo the comment anyway.

HafizBeyy avatar Feb 26 '25 08:02 HafizBeyy

i just want to see it.

HafizBeyy avatar Feb 26 '25 08:02 HafizBeyy

Thanks for that screenshot, I understand now! So the procedure is:

  1. make a new Note or a comment or a Note
  2. upload it to OSM servers
  3. ...some time passes...
  4. click in the undo menu on that uploaded Note to see what is was (without the intention to actually undo it)

but if fails to display note comment with message "This edit is already synced and cannot be undone", while preferred solution would be to display information window with note text (as it would if the Note was not uploaded yet), but replace regular buttons Cancel and Undo with just one button Cancel (cannot undo this change), as that would allow user to see what note it was.

Makes sense to me (although since I run in manual upload mode, it would very rarely affect me personally).

So, yes, since the same thing is applicable to vanilla StreetComplete, I would suggest you open new Feature Request issue there first. If it gets accepted there, great! (If not, you can ask again here...)

mnalis avatar Feb 26 '25 12:02 mnalis

Apart from this, should i also open this issue on main StreetComplete repository?

So, yes, since the same thing is applicable to vanilla StreetComplete, I would suggest you open new Feature Request issue there first

@HafizBeyy did you manage to open an issue on main StreetComplete repository?

mnalis avatar Apr 21 '25 21:04 mnalis

No i didnt. Should i?

HafizBeyy avatar Apr 22 '25 04:04 HafizBeyy

@HafizBeyy did you manage to open an issue on main StreetComplete repository?

No i didnt. Should i?

@HafizBeyy Yes please. If the feature can be accepted in StreetComplete, it would benefit both projects, and also greatly simplify maintenance of SCEE.

mnalis avatar Apr 22 '25 11:04 mnalis