Don't ask for building color if building is underground

[RubenKelevra]

After SCEE asked me if a building is completely underground it continued to ask me what the building color is.

How to Reproduce

• Go to a building on the map with the following tags:

• See a building color quest pop up.

Expected Behavior No building color quest

Does it happen in normal StreetComplete? Nope, this quest does not exist in SC

Versions affected Android 12 SCEE Version 58.22

[mnalis]

@RubenKelevra would you perhaps like to make a PR for it? It is very easy:

• fork the SCEE repo on GitHub
• edit the elementFilter for AddBuildingColour quest to skip underground buildings (similarly how it is skipped in e.g. AddBuildingType - i.e. just add that one line)
• click on the "Create pull request" that GitHub will asks you, and select Helium314/modified as a branch to pull into.

[RubenKelevra]

Well, I would, but I have neither a build setup for the app setup, nor does the master of the app currently work on my device - as SC 59.x is still crashing for me at startup:

https://github.com/streetcomplete/StreetComplete/issues/5850

Apart from that, I have zero knowledge of Java / Kotlin. ;)

[mnalis]

Well, I would, but I have neither a build setup for the app setup

Luckily @RubenKelevra, none is needed to make a pull request for this! If you click on those 2 links above I've sent, you'll see that is a simple matter of editing one text string and adding and location != underground line into it (at the end)

Apart from that, I have zero knowledge of Java / Kotlin. ;)

That is not needed either. Knowing how to copy/paste one line of text between two other lines should be sufficient :smiley_cat:

So it would change like this:

          and !building:colour
          and (!indoor or indoor = no)
          and wall !~ no
+         and location != underground

nor does the master of the app currently work on my device - as SC 59.x is still crashing for me at startup

I've seen that issue... Hopefully it will get resolved, but in order to make a "Pull request" it is not needed for you to have a Kotlin development environment or even have any ability to create .apk files. It is just a matter of editing a text file (can be done in GitHub web browser window too!) and clicking a few links in a webpage.

If you'd like to try, I can help you around if you get stuck, but I think you can do it easily by yourself. You already know how to do 1. fork the repo, which is about as hard as the rest of the steps :smiley:

[mnalis]

But, if you would like to test your changes too (which is not required, we can do that for you), it is also easily achievable without any android development knowledge or having Android development tools installed....

So, if you want, after doing the edits, in GitHub you could click on Actions tab in your fork and choosing Build debug APK, and GitHub would prepare it for you automatically.

Best thing? Such a development build has different appid (and yellow icon color instead of blue), so it can be installed alongside your existing (broken) SC or SCEE installation, without affecting it at all. That would enable you not only to check if you've fixed this issue with underground building, but also to play around trying to reproduce your crashing issue.

But as noted above, building APK is not required to make a pull request, it is just additional thing if you want to do it.

[HolgerJeromin]

I did a SC PR just with the mobile browser, fetched the build, tested it while being on holiday :)

Hardest part was to extract the apk out of the zip file :-P

[mnalis]

So, @RubenKelevra, would you like to give it a try to fix this one, as explained at https://github.com/Helium314/SCEE/issues/635#issuecomment-2328825902 ?

It is not hard, you don't need to know to program in Kotlin or having anything setup on your computer - just being able to access GitHub in web browser is enough. And I'm here to guide you if you get lost. (but there really is not much chance of that happening, it's pretty straightforward - clicking few buttons and adding one line in one file).