SCEE icon indicating copy to clipboard operation
SCEE copied to clipboard

Unable to zoom in all the way on satellite/aerial imagery

Open Brendan-D15 opened this issue 1 year ago • 13 comments

Zooming in all the way on the map doesn't render tiles at the highest zoom available.

How to Reproduce Zoom in all the way. Compare highest zoom at any location with what can be achieved using the same source in a browser/other tools.

This happens with both the default tile source, and other sources ex: https://clarity.maptiles.arcgis.com/arcgis/rest/services/World_Imagery/MapServer/tile/{z}/{y}/{x}

Expected Behavior Zooming in all the way should render the tiles at the highest zoom available.

Does it happen in normal StreetComplete? Normal StreetComplete doesn't show satellite imagery (that I could find).

Versions affected Android Version: 14 SCEE version: 58.21

Brendan-D15 avatar Aug 24 '24 19:08 Brendan-D15

You would need to specifiy which zoom levels are available, which is not possible currently. For simplicity SC default value is used.

Helium314 avatar Aug 24 '24 19:08 Helium314

What does "SC default value" mean? There is no option to connect satellite images there. The problem appeared in recent versions. In earlier versions this problem did not exist.

mic140 avatar Aug 24 '24 21:08 mic140

It seems that there is a limit on the maximum zoom. It should either be removed or increased to at least 18

mic140 avatar Aug 24 '24 21:08 mic140

The problem appeared in recent versions. In earlier versions this problem did not exist.

Can you specify in which version the problem did not exist? (even better, if you can triage which was the first SCEE version where the problem appeared?)

(A screenshot of the same area working at maximum zoom in older SCEE version and not working with newer one might be helpful to clarify the situation)

mnalis avatar Aug 24 '24 22:08 mnalis

I did some research. The problem definitely wasn't in version 58.21. It appeared in version 59.0 alpha 1 Screenshot_2024-08-25-06-09-31-035_de westnordost streetcomplete expert Screenshot_2024-08-25-06-04-11-863_de westnordost streetcomplete exper2 There is also an unpleasant feature that can be seen on the screenshots - silhouettes of buildings that cannot be turned off. They sometimes interfere with seeing the details of the image.

mic140 avatar Aug 25 '24 03:08 mic140

What does "SC default value" mean?

Vector tiles used by SC also have a max zoom level

Helium314 avatar Aug 25 '24 04:08 Helium314

It should either be removed or increased to at least 18

Have you actually tried to zoom to level 18 with the default raster tile source? E.g. looked at the beautiful imagery in https://server.arcgisonline.com/arcgis/rest/services/World_Imagery/MapServer/tile/18/141833/93384

Helium314 avatar Aug 25 '24 04:08 Helium314

The problem definitely wasn't in version 58.21. It appeared in version 59.0 alpha 1

If there is a difference to the previous version that should be fixable by finding the right place, and the previous maxzoom level.

Helium314 avatar Aug 25 '24 05:08 Helium314

The problem definitely wasn't in version 58.21. It appeared in version 59.0 alpha 1

If there is a difference to the previous version that should be fixable by finding the right place, and the previous maxzoom level.

I didn't understand what you meant. Isn't it obvious from the screenshots that the same place on the second screenshot is clearly not downloaded?

mic140 avatar Aug 25 '24 07:08 mic140

By the way, there is no such problem in version 58.22

mic140 avatar Aug 25 '24 08:08 mic140

It should either be removed or increased to at least 18

Have you actually tried to zoom to level 18 with the default raster tile source? E.g. looked at the beautiful imagery in https://server.arcgisonline.com/arcgis/rest/services/World_Imagery/MapServer/tile/18/141833/93384

I wonder where you found such a tile? Mine shows this: https://server.arcgisonline.com/ArcGIS/rest/services/World_Imagery/MapServer/tile/18/85660/157174

mic140 avatar Aug 25 '24 09:08 mic140

For a specific example, around Disney World (Orlando, Florida), from the app:

IMG_20240825_072438

This same tile (highlighted in yellow) can be seen with a zoom of 21 (from the source): 573327

https://server.arcgisonline.com/ArcGIS/rest/services/World_Imagery/MapServer/tile/21/875883/573327

Brendan-D15 avatar Aug 25 '24 14:08 Brendan-D15

The release of version 59.0 did not change the situation

mic140 avatar Sep 12 '24 20:09 mic140

I can confirm this bug for Version 59.2, the aerials are basically useless.

RubenKelevra avatar Oct 18 '24 23:10 RubenKelevra

This is what I got at zoom 21: Screenshot_20241227-115903_SCEE_Dev This is actually useless, not some it's-not-the-best-so-I-call-it-useless kind of useless. And I'm not going to do a change where even in an area with reasonably good aerial imagery user may see something like this.

Helium314 avatar Dec 27 '24 11:12 Helium314

@Helium314 I can't follow your argument here. You're saying everyone must now live with completely useless aerials at what, zoom level 17 or so because in some areas there's no zoom level 21 available?

Here's the state of Aerials in SCEE. I don't see any use case where looking at this would be useful.

Screenshot_2024-12-27-12-35-37-595-edit_de westnordost streetcomplete expert

RubenKelevra avatar Dec 27 '24 11:12 RubenKelevra

If there is a difference to the previous version that should be fixable by finding the right place, and the previous maxzoom level.

This seems to be the location: https://github.com/mnalis/StreetComplete/commit/caf9da60543756ce3f807cd63b252ae0f0c982b6#diff-41f6be370d630835820f7f9484bc80868d12a5b58d6b75d2c976d0dbd85b5db0L662

Screenshot in SCEE 58.2 and master with that patch (click to expand...)

Regular SCEE 58.2 (zoom in to the maximum): small_Screenshot_20241227_185142_SCEE

Dev version with patch of maxzoom=21: small_Screenshot_20241227_185148_SCEE Dev

If people want debug APK to try how it works for them, it can be found here.

21 it too much of zoom level however for default imagery, because if I zoom in more, the satellite images disappear.

I can try to find what was the previous value, but it would be nicest if one could manually specify the maxzoom in Tile source for satellite / aerial images (as different URLs will have different maxzoom, and we can't autodetect it for TMS AFAIK)

There is also an unpleasant feature that can be seen on the screenshots - silhouettes of buildings that cannot be turned off. They sometimes interfere with seeing the details of the image.

@mic140 Are those buildings shown only in SCEE master (and not in latest 58.2 release)?

Anyway, you can go in Settings / Data management / Tile source for satellite / aerial images and turn on the Hide labels . That should remove the OSM maps, and show only Satellite imagery so you can have the clearest view. (and if you want some of the things to be displayed but not others, you can enable custom overlay specifying exactly what you want to see. And overlay is easy to turn off/on quickly, esp. if you use Settings / UI / Show overlay quick selector)

mnalis avatar Dec 27 '24 18:12 mnalis

That should remove the OSM maps, and show only Satellite imagery so you can have the clearest view

Yes, thank you, it helped, but with the current quality of displaying images, their use is almost useless. I don't understand why it is impossible to simply return the way satellite images were displayed up to and including version 58.22? After all, there is not even a 17 zoom there now. It would be nice with it.

mic140 avatar Dec 28 '24 03:12 mic140

If people want debug APK to try how it works for them, it can be found here.

This is what is needed! If this is included in the main version, it will be great. And the fact that in some places, starting from a certain zoom, the image disappears - this is not as tragic as what is now in the main version. And of course, the ability to save several layers of satellite images and switch between them is very much lacking.

mic140 avatar Dec 28 '24 04:12 mic140

This is what I got at zoom 21: Screenshot_20241227-115903_SCEE_Dev This is actually useless, not some it's-not-the-best-so-I-call-it-useless kind of useless. And I'm not going to do a change where even in an area with reasonably good aerial imagery user may see something like this.

Why not add the ability to enable this mode in the settings? Let the user choose what is most convenient for him. For example, I am quite satisfied with how it is implemented here: https://github.com/mnalis/StreetComplete/actions/runs/12517753154

mic140 avatar Dec 29 '24 18:12 mic140

Why not add the ability to enable this mode in the settings?

@mic140 @Brendan-D15 @RubenKelevra I've tried to implement custom maxzoom (defaulting to 21) on that satellite/aerial imagery URL.

Debug .APK (can be run alongside regular SCEE) is available at https://github.com/Helium314/SCEE/pull/708 - would you please try it out and let me know how it works for you?

mnalis avatar Dec 30 '24 05:12 mnalis

would you please try it out and let me know how it works for you?

Works for me!

mcliquid avatar Dec 30 '24 10:12 mcliquid

@mnalis this version works fine:

Screenshot_2024-12-30-11-17-00-683-edit_de.westnordost.streetcomplete.expert.debug.jpg

vs the broken Version 60:

Screenshot_2024-12-30-11-07-15-440-edit_de.westnordost.streetcomplete.expert.jpg

RubenKelevra avatar Dec 30 '24 10:12 RubenKelevra

would you please try it out and let me know how it works for you?

This option is already quite normal. However, I got the impression that at zooms smaller than the maximum, the application does not load the image corresponding to the current zoom. This is visible in the screenshots from two applications - SCEE and Osmand: Screenshot_2024-12-30-13-19-27-954_de westnordost streetcomplete expert debug Screenshot_2024-12-30-13-19-14-868_net osmand plus

mic140 avatar Dec 30 '24 12:12 mic140

Why not add the ability to enable this mode in the settings?

@mic140 @Brendan-D15 @RubenKelevra I've tried to implement custom maxzoom (defaulting to 21) on that satellite/aerial imagery URL.

Debug .APK (can be run alongside regular SCEE) is available at #708 - would you please try it out and let me know how it works for you?

Oh yeah, this is a lot better. Thanks!

I tested out setting the maxzoom too high and too low and it works great. Zooming in too much results in the "map data not available yet" warning tiles. Ideally this would be just a label that shows up on top of the last rendered tile, but it's better than what it was.

Zooming back out is ok. It would be nice if it held on to the max zoom tiles a bit longer than how it handles it now... But that's another issue entirely. Also, trying to modify that is not going to go over well until the "map data not available yet" (overzoom issue) is handled a bit differently.

Brendan-D15 avatar Dec 31 '24 04:12 Brendan-D15

Zooming in too much results in the "map data not available yet" warning tiles. Ideally this would be just a label that shows up on top of the last rendered tile, but it's better than what it was.

Yeah, unfortunately that is verbatim image that TMS server returns when overzoomed, and not much that SCEE could do about that. I've suggested some heuristics how it might be detected and better handled by MapLibre in https://github.com/maplibre/maplibre-native/issues/3110, so feel free to provide comments/likes/alternative ideas there.

mnalis avatar Dec 31 '24 14:12 mnalis

However, I got the impression that at zooms smaller than the maximum, the application does not load the image corresponding to the current zoom. This is visible in the screenshots from two applications - SCEE and Osmand:

@mic140 huh, interesting. However, if that is the case, it seems like general MapLibre issue (i.e. I do not think SCEE has control over when MapLibre will start fetching which zoom level), so should be reported in their issue tracker. Please do link back to here if you open the issue there, so that interested parties may follow.

mnalis avatar Jan 07 '25 11:01 mnalis