SCEE icon indicating copy to clipboard operation
SCEE copied to clipboard

Add Quest: roof:material

Open ravenfeld opened this issue 1 year ago • 5 comments

I'm going to split the request in 2. #443

Creating a quest to add roof material

The most complicated part is making the images once you understand how it works ;)

Screenshot_20240702_223022

ravenfeld avatar Jul 02 '24 20:07 ravenfeld

Similar to builing material quest: please reduce size of the images, it's more than 5 MB currently, and the strings could be re-used (after building material quest is merged). Other than that it's mostly minor things:

  • not sure if tin and generic metal should be separate. I wouldn't be able to tell that a roof is made of tin, probably same for zinc. But maybe it's easy if you have some experience.
  • I found the concrete and tar paper images not really helpful. For tar paper, just some increased contrast might help a lot (and maybe for concrete too)
  • the asphalt image looks strange, on my phone at first I thought it was a lake
  • quest icon could be nicer, but at the same time making a nice looking tile roof or whatever seems to be not worth the effort

Helium314 avatar Feb 04 '25 17:02 Helium314

@Helium314 I have updated this PR if it is still requested by some

ravenfeld avatar May 03 '25 16:05 ravenfeld

Thanks @ravenfeld! I'll do another test run soon. From code I see you still using completely new strings for all materials, but we could reuse some of the existing strings e.g. for bamboo. But I can change this myself if you prefer.

Helium314 avatar May 04 '25 15:05 Helium314

I did a short test, and sometimes found it surprisingly difficult. But I'm far from an expert on those materials.

One thing I found that might warrant adding a hint: Where to Eternit plates / tiles go? Are they roof tiles or Eternit? The Eternit image shows only corrugated sheet, and I'm not sure whether it could also count as roof tiles. Similar questions could arise for other things like solar panel roof tiles.

Helium314 avatar May 04 '25 16:05 Helium314

@Helium314 I'll look into the strings this week. For the rest, I'm no expert. I just took a question that some people were asking about and looked at the wiki. Maybe we should check with them?

ravenfeld avatar May 04 '25 19:05 ravenfeld