SCEE icon indicating copy to clipboard operation
SCEE copied to clipboard

Published 20 hours ago • verified publisher icon Helium314

Fix when changing between 2 custom overlays

Open ravenfeld opened this issue 1 year ago • 8 comments

I noticed that when I changed the overlay between 2 customs the icon didn't update. There was even the beginnings of a fix in the code, but that doesn't change anything because it wasn't a view refresh problem.

This is due to the fact that the reference was not changed because there is only one instance in the OverlayRegistry.

  • [x] So I've changed it to use a reference on the objects.
  • [x] I've also removed the need to always look at the prefs (pref level is not recommended by google and it's not even asynchronous).

I hope it won't be a problem during the rebases with SC

ravenfeld avatar Jul 02 '24 18:07 ravenfeld

I would rather have minor issues in SCEE than larger deviation from SC, because SC code changes frequently and merging can be quite time consuming.

So if possible, try to keep code that is the same as SC stable, and do the changes is SCEE-only code sections. (I did not check, because SC merge created merge conflicts already)

Btw I guess this change will be gone anyway when the involved parts are changed to compose.

Helium314 avatar Jul 16 '24 14:07 Helium314

I'll see if it's still there with the new SC code.

ravenfeld avatar Jul 16 '24 19:07 ravenfeld

I had another short look, and I think it would be best to wait until main screen UI is re-done in compose. Not sure how long it will take... currently the idea is to do it right after switching to MapLibre, but that's blocked by a rather critical bug.

Helium314 avatar Jul 24 '24 10:07 Helium314

Don't worry, you want me to create a label for the PR we're blocking? Like an "on hold" label?

ravenfeld avatar Jul 28 '24 15:07 ravenfeld

Good idea, I added a label.

Helium314 avatar Jul 28 '24 19:07 Helium314

@Helium314 Hi, I'm back from holiday and back to work. I was wondering if the compose version of SC is more stable now and if I could get back to work on this branch?

ravenfeld avatar Sep 28 '24 18:09 ravenfeld

Sorry for the late reply. I would like to wait until https://github.com/streetcomplete/StreetComplete/pull/5799 is implemented.

Helium314 avatar Oct 08 '24 18:10 Helium314

The main UI is now in compose, including the overlay dropdown. Looks like icon now changes when switching between custom overlays. I only coarsely looked over the PR now, and it seems you also have changes that don't seem clearly related to the icon. Is there anything left you think should be implemented?

Helium314 avatar Dec 27 '24 16:12 Helium314