SCEE icon indicating copy to clipboard operation
SCEE copied to clipboard

Add "chipseal" as road surface type

Open ravenfeld opened this issue 1 year ago • 20 comments

The topic has been closed on the StreetComplete side, so I've asked for it to be reanalysed.

https://github.com/streetcomplete/StreetComplete/issues/4265

But I think the answer, as so often, will be no.

Can I propose my PR here? Or would you prefer to wait for a negative answer before coming back here?

ravenfeld avatar Jul 01 '24 11:07 ravenfeld

I would think you should at least wait for at least a week or so for an possible acceptance there, especially since you already asked there. I've tried to add some more recent data and pros/cons and possible alternatives in that linked SC thread.

mnalis avatar Jul 01 '24 19:07 mnalis

I didn't know how responsive SC was. And it's more for an opinion of how it works. I've read your comments and they've almost convinced me that it shouldn't be on SC. In France I have the impression that people know the difference, but maybe not elsewhere, so maybe it's better that it's not on SC.

ravenfeld avatar Jul 01 '24 19:07 ravenfeld

From my point of view, the change could already be integrated into SCEE. There are also some roads with chipseal in my rural area. If SC accepts it, the changes can be transferred quite easily.

mcliquid avatar Jul 03 '24 18:07 mcliquid

While I don't think a separate chipseal surface would be a useful addition, it would still be acceptable to have it as a choice for surface. When adding, make sure you consider special treatment of existing chipseal tagging (I think there is some, if it wasn't removed meanwhile).

Helium314 avatar Jul 16 '24 19:07 Helium314

While I don't think a separate chipseal surface would be a useful addition, it would still be acceptable to have it as a choice for surface. When adding, make sure you consider special treatment of existing chipseal tagging (I think there is some, if it wasn't removed meanwhile).

I didn't understand what you meant by "When adding, make sure you consider special treatment of existing chipseal tagging (I think there is some, if it wasn't removed meanwhile)."

ravenfeld avatar Jul 16 '24 20:07 ravenfeld

If it helps, here is already the image in all sizes: android-export.zip

mcliquid avatar Jul 16 '24 20:07 mcliquid

I didn't understand what you meant by "When adding, make sure you consider special treatment of existing chipseal tagging (I think there is some, if it wasn't removed meanwhile)."

Possibly chipseal has some special treatment comparend to a "valid" SC surface, which might need to be adjusted.

Helium314 avatar Jul 17 '24 03:07 Helium314

I'm not sure if I'm interpreting correctly what you're trying to point out, but as far as I know there's only a dispute that chipseal should not be assigned by armchair mapping using only the aerial image, because according to some mappers the maximum you can correctly recognize is paved, but not whether it's asphalt, concrete or chipseal. However, as SCEE is mapped on site, I still consider chipseal to be acceptable. What is known for sure is that chipseal is so little used that it is only the 37th most common value.

mcliquid avatar Jul 17 '24 11:07 mcliquid

I checked, and chipseal is treated as synonym of asphalt. This needs to be changed.

Helium314 avatar Jul 18 '24 08:07 Helium314

I checked, and chipseal is treated as synonym of asphalt. This needs to be changed.

You're talking about SCEE codebase here (for those "checked is synonym" & "needs to be changed"), right? Not the wiki or something else?

mnalis avatar Jul 18 '24 09:07 mnalis

Yes. Though the comment does not matter

Helium314 avatar Jul 19 '24 06:07 Helium314

Last week I had the unique opportunity to find a road that had just been renewed with ‘chipseal’. I took some photos that show both the old condition, where the black tar (tarmac/bitumen) is clearly visible through the small and fine gravel, and the brand new, fresh and still loose area, where only the small and fine gravels are visible. I've uploaded a lot of pictures into this wikimedia category: https://commons.wikimedia.org/wiki/Category:Chipseal_pavements

mcliquid avatar Jul 31 '24 07:07 mcliquid

Can I propose my PR here?

@ravenfeld With extra pictures, I think everything needed is ready, so you can proceed with PR for surface=chipseal (if you're still interested, of course)

mnalis avatar Jul 31 '24 11:07 mnalis

Which one do you want me to display? The rest of the code is already operational on my repo so it's quick to propose it as normal unless compose has also caused the quest to work.

ravenfeld avatar Jul 31 '24 11:07 ravenfeld

Well I don't have chipseal around here so I cannot claim which is most representative, but many (especially on small screen) might look like fine_gravel instead, so are not good illustrations IMHO...

That being said, I'd probably choose this one (or alternatively this)

mnalis avatar Jul 31 '24 12:07 mnalis

I would agree with the selection. The first picture clearly shows the mixture of tar/bitumen and fine chippings/gravel. chipseal.zip

mcliquid avatar Jul 31 '24 17:07 mcliquid

@mcliquid looking at the smaller scale version you've prepared; I think maybe it would be better (instead of scaling whole original picture to mdpi->xxdpi scales), to instead cut from a center of the original picture and use that for generating pictures? That should probably make details somewhat bigger & more visible IMHO.

mnalis avatar Jul 31 '24 21:07 mnalis

@mnalis If you think so, here are the new pictures - the section in the center has always been cropped to fit the new resolution. chipseal_centered.zip

Perhaps I am able to point out once that we are in the Expert Edition here and it can be assumed that users should know what value they are setting independent of the picture. And incidentally, there will not be a suitable translation of "Chipseal" for every language I guess. At least I am not aware of any in German. Rollsplitt seems to be the best translation but I would not be happy with that tbh because "Rollsplitt" is more or less "fine gravel" (without any bitumen).

mcliquid avatar Aug 01 '24 09:08 mcliquid

the section in the center has always been cropped to fit the new resolution.

oh, ok then, I missed that

we are in the Expert Edition here and it can be assumed that users should know what value they are setting independent of the picture.

true, it was only minor idea improvement anyway

mnalis avatar Aug 02 '24 15:08 mnalis

oh, ok then, I missed that

I was only referring to the latest ZIP file, not the first version!

mcliquid avatar Aug 02 '24 17:08 mcliquid