SCEE
SCEE copied to clipboard
Helium314
Disabling overlay does not automatically remove coloring
How to Reproduce
- enable overlay (either via side quick-overlays, or via regular overlay button at the top)
- disable overlay (click again on right side quick-overlays, or select
Nonein regular overlay button - notice the Overlay coloring remains, even if overlay is disabled
- pan or resize map a little
- only now Overlay coloring is removed
Expected Behavior
The overlay coloring should be removed at step 3.
Does it happen in normal StreetComplete? No, SC 57.4 works as expected
Versions affected SCEE 57.4, Android 14
Video
https://github.com/Helium314/SCEE/assets/156656/769198d7-a9af-4f5b-92fd-20f90e3f260a
Can't reproduce, does it always happen? (anyway, I'm probably not going to do anything here as MapLibre is coming)
Can't reproduce, does it always happen?
Ah... It seems no, not always.
Although that day, even when closing and reopening app several times, it seemed it was being 100% reproducible. Today I tried and it seems it only happens when location is off, but works ok when it is on. And now after several tries it seems it works even when location is off. :confused:
I know MapLibre might change a lot of those things; I've reported it as (at the time) it seemed to always happen in SCEE and never in SC; and I have no idea how long-term that MapLibre transition (being a huge effort) is supposed to take (weeks? months? years?)
(anyway, I'm probably not going to do anything here as MapLibre is coming)
Sure, no worries. I'll try to reproduce more thoroughly when MapLibre version is released, then.
(weeks? months? years?)
There is mostly minor stuff left, and some bug in MapLibre that sometimes stop overlay symbols from being displayed. (though the migration will be a setback for SCEE, I will likely remove a bunch of map-related features and slowly re-add them over time)
only happens when location is off
That actually indicates some missing call to draw the map (the location causes frequent redraw due to compass updates). I remember I fixed this in SC a while ago, maybe missed some additional place in SCEE.
You always reproduce, I don't reproduce in 58.1
Neither could I always reproduce, see this update in https://github.com/Helium314/SCEE/issues/545#issuecomment-2125558016
In any case, this is blocked until MapLibre version is released, as it makes little sense to invest time debugging code which will be replaced very soon.
I haven't noticed it anymore in SCEE 60.0 (which is Maplibre), so hopefully it is solved. It anyone still notices that problem with recent SCEE, please do leave a comment here (or open a new issue)!