SCEE icon indicating copy to clipboard operation
SCEE copied to clipboard

Quest order is not applyed/saved

Open dr2okevin opened this issue 1 year ago • 8 comments
trafficstars

When I move quest around, they get back to their original position as soon as I start to drag another quest.

How to Reproduce Go into settings and move the quests

Expected Behavior A moved quest should stay where it was dropped by me

Does it happen in normal StreetComplete? The bug doesn't appear in StreetComplete

Versions affected SCEE v57.0 Android 9

dr2okevin avatar Mar 10 '24 09:03 dr2okevin

Can' reproduce (on 57.1). Does it happen for all profiles?

Helium314 avatar Mar 10 '24 10:03 Helium314

Strange thing, I created a new profile, and I had the same error there too. Then I switched back to the default profile, and then the error diapered there, but is still on the new profile.

edit: looks like it happens only when I place something on the first position.

dr2okevin avatar Mar 10 '24 10:03 dr2okevin

First quest is fixed to note quest in SC, but has been unlocked on user request iirc. The moving system is probably not built for moving something to the first position...

I see it as minor inconvenience, so it might be a while util I find time to look into it.

Helium314 avatar Mar 10 '24 14:03 Helium314

Can' reproduce (on 57.1). Does it happen for all profiles?

Where did you get version 57.1?

mic140 avatar Mar 14 '24 09:03 mic140

https://github.com/Helium314/SCEE/releases

HolgerJeromin avatar Mar 14 '24 10:03 HolgerJeromin

https://github.com/Helium314/SCEE/releases

That file after installation turns out to be version 57.0

mic140 avatar Mar 14 '24 11:03 mic140

I've also had a look, and it's quite complicated what's been put in place for just one order in a list. To correct the problem you'd have to revise a lot of SC's code, and I don't think that's a good idea.

You can't move an item to the 1st position but the 1st position can be moved for information.

perhaps the SC side should be asked to review their order management. I don't understand why it's so complex, but I don't know the code well enough to suggest a solution.

ravenfeld avatar Jul 03 '24 10:07 ravenfeld

perhaps the SC side should be asked to review their order management.

Why? In SC you can't move the note quest away from first position, so this bug cannot occur and thus I don't think there is need to bother.

I don't understand why it's so complex

Just saving the full order would complicate adding new quests at (approximately) the correct position, and massively increase the size of shared quest presets, which might create issues with the QR code.

Helium314 avatar Jul 16 '24 17:07 Helium314