SCEE icon indicating copy to clipboard operation
SCEE copied to clipboard

Soundex test Osmose error is test class

Open matkoniecz opened this issue 1 year ago • 3 comments

Item type 5050/1 is not shown in Osmose at https://osmose.openstreetmap.fr/en/map/#zoom=18&lat=50.06123&lon=19.938302&item=xxxx&level=1%2C2%2C3&issue_uuid=adde1c99-b1b0-fe6a-19dc-2d042f51ba6d but is show in SCEE

It is shown as "Osmose quest: Soundex test"

Proposed Solution Stop showing this error class by default

matkoniecz avatar Dec 31 '23 10:12 matkoniecz

At least for me it is shown: image https://osmose.openstreetmap.fr/en/issue/f3e4887c-6a2d-1fa1-f7cd-597f64e1b435

mcliquid avatar Dec 31 '23 10:12 mcliquid

weird, it is not showing up for me

and either way it is incomprehensible what it is trying to achieve so hiding in in SCEE by default makes sense

screen

matkoniecz avatar Dec 31 '23 12:12 matkoniecz

weird, it is not showing up for me

It's the red pin with the black square on your screenshot. On the Osmose website, pins are often at the wrong location, no idea when and why.

it is incomprehensible what it is trying to achieve

That's also true for the "normal" Osmose issue, unless you go to details and check the description (usually such informtion is in the subtitle). The description reads "A street name "sounds" similar to that of another street but is not spelled the same way.". Since the issue is on a statue and not on a street, there seems to be a problem with the check.

Helium314 avatar Dec 31 '23 13:12 Helium314

I'll close this issue, as this soundex is a valid osmose issue and the confusion is just caused by name, which is coming from osmose and not SCEE.

Helium314 avatar Jul 28 '24 20:07 Helium314

What about proposed solution with "stop showing this error class by default"?

matkoniecz avatar Jul 28 '24 21:07 matkoniecz

Well, isn't the whole of Osmose quest disabled by default? There are certainly a number of Osmose quests that I too find too problematic; but current solution seems fine to me - Osmose quest disabled by default, and if enabled, show all high-class priorities only.

Also note that not only is it chooseable in settings, but users are also offered to disable certain warning classes each time when they are shown (via Other answers / Remove issues with same...) if they'd prefer never to see that specific Osmose warning ever again.

And if some specific Osmose warning produces too many false positives globally, perhaps it should be suggested there that its class should be reduced? Or that it's filter should be updated to remove most of false positives? If there are many FP, surely it affects much more than just SCEE (but instead affects all Osmose users)?

mnalis avatar Jul 29 '24 04:07 mnalis

Well, isn't the whole of Osmose quest disabled by default?

Yes, but after enabling it I would expect to not get such broken reports - especially one that was reported as broken long time ago and not fixed

still, it is relatively minor issue

matkoniecz avatar Jul 31 '24 13:07 matkoniecz

What about proposed solution with "stop showing this error class by default"?

Sorry, I had overlooked that. So far (I think) I only disabled Osmose issues by default if there is a corresponding quest, or if SCEE is not suitable (relation-related issues). For the soundex issue I'm not sure. The title really is not understandable, but at the same time the issue can easily be solved in SCEE (if it's an actual issue).

Helium314 avatar Aug 07 '24 20:08 Helium314