SCEE icon indicating copy to clipboard operation
SCEE copied to clipboard

Osmose Quest: Create node

Open amenk opened this issue 2 years ago • 15 comments

Use case

Support validation of large set of to-be-imported POIs

Proposed Solution

Osmose already supports fix nodes with id = 0. The quest could also support this

I am generally wondering if this is feasible. Does the StreetComplete infrastructure allow creating and uploading new POIs?

amenk avatar Aug 15 '22 18:08 amenk

SC should be able to create nodes... I never tried, but looking at the code for splitting ways it could be quite simple. Need to test it though...

Helium314 avatar Aug 18 '22 20:08 Helium314

Uploading new nodes with SC seems to be simple, but creating quests that are not referring to an existing element requires considerable changes on how things work internally...

Helium314 avatar Aug 21 '22 11:08 Helium314

Okay, thanks for the feedback. We are still looking into other ways to do our import / on the ground verification

amenk avatar Aug 21 '22 12:08 amenk

Creating nodes will probably be possible in 48.0. But there is still the question how to add the quests. I guess duplicating the way how note quests work is the easiest way, which still quite a bit of work.

How do you provide the POIs that might be imported?

Helium314 avatar Sep 29 '22 21:09 Helium314

Creating nodes will probably be possible in 48.0.

Cool

How do you provide the POIs that might be imported?

The idea was to supply them via Osmose (whether the public instance or a private one)... but it's all not thought through yet. We can assign this low priority.

amenk avatar Sep 30 '22 06:09 amenk

So now with https://github.com/Helium314/StreetComplete/commit/59c822212573c4f3dc302d5b23ba5d153421cb92 osmose quests works independently from elements.

But I don't see how to get the "fixes". I can see them in the browser, but they are not in the files created by export. Do you know I can get all issues inside a bbox with "fixes"?

Helium314 avatar Oct 01 '22 15:10 Helium314

Do you mean this here: "fixables" https://wiki.openstreetmap.org/wiki/Osmose/api/0.3

Looks like it would need a second request?

amenk avatar Oct 02 '22 11:10 amenk

So apparently it's supposed to work if I use &fixable=online or &fixable=josm parameter. But the dowloaded csv doesn't contain any of the fix suggestions...

I tried all links/formats listed under export, except JOSM, which doesn't actually download, but complain about not having a connection to my computer (localhost:8111).

Helium314 avatar Oct 02 '22 14:10 Helium314

Can you post the full link with bbox? Do those expected fixables show up in the web GUI of osmose?

amenk avatar Oct 02 '22 14:10 amenk

Browser: https://osmose.openstreetmap.fr/en/map/#zoom=14&lat=46.96189&lon=3.07153&item=xxxx&level=1&fixable=online CSV: https://osmose.openstreetmap.fr/api/0.3/issues.csv?zoom=14&item=xxxx&level=1&fixable=online&limit=500&bbox=3.014888763427735%2C46.93608137619495%2C3.1281852722167973%2C46.9876887066222

For both issues there is some fixable, and I can get them if I download the issue: https://osmose.openstreetmap.fr/api/0.3/issue/d1c57e99-f717-08df-729b-75bbeb0344ff But downloading each issue separately may take rather long... considering that Osmose sometimes is rather slow, this is simply not acceptable (much longer download time, and probably more load on the server).

Helium314 avatar Oct 02 '22 16:10 Helium314

But it needs only to be downloaded it someone decides to solve a specific quest, so it might eventually be feasible?

amenk avatar Oct 02 '22 16:10 amenk

Well, this is planned to be done via osmose, so it would affect everyone who uses the osmose quest. If the connection is bad, each request may take seconds to complete, which is rather horrible if you have something like 100 issues to download.

@frodrigo is there a simple way for downloading all issues and the corresponding fixables (if any) in a bbox or tile? So far I only see how to get them for each issue separately.

Helium314 avatar Oct 02 '22 17:10 Helium314

So far I only see how to get them for each issue separately.

Yes. By design. To avoid server load. The ides is to only download details, when user interact with the issue.

bbox or tile

Tile is preferred, because it can be cached (again avoid server load).

Just to show on map, you even does not need full.

frodrigo avatar Oct 02 '22 18:10 frodrigo

Yes. By design. To avoid server load. The ides is to only download details, when user interact with the issue.

StreetComplete is intended to also allow offline use, so I would need to download everything in a certain region anyway... do the tiles contain the fixables?

Tile is preferred, because it can be cached (again avoid server load).

So I could switch to tile, as SC downloads are always in zoom 16 tiles anyway. How does this work? Everything for tiles I tried using https://osmose.openstreetmap.fr/api/docs returned 404, e.g. https://osmose.openstreetmap.fr/0.3/issues/16/34447/23453.mvt?level=1%2C2%2C3&full=false&zoom=16&limit=100&useDevItem=false&status=open.

Helium314 avatar Oct 03 '22 04:10 Helium314

StreetComplete is intended to also allow offline use, so I would need to download everything in a certain region anyway... do the tiles contain the fixables?

Tiles are minimalist, no fixable, no full.

So I could switch to tile, as SC downloads are always in zoom 16 tiles anyway.

Tiles only contains 50 issues max.

But at level 18, there is all issues.

It was not designed for offline use.

I open an issue to do better offline support : https://github.com/osm-fr/osmose-frontend/issues/404

frodrigo avatar Oct 03 '22 08:10 frodrigo