toolbar modes

[codokie]

I added a list preference to the new toolbar section that allows one to select one of the following toolbar modes:

1. Hidden -> hides the strip container completely when the main keyboard is open
2. Toolbar keys -> shows only the selected toolbar keys. Hides the expand toolbar key*
3. Suggestion strip -> shows only the suggestion strip & pinned keys. Hides the expand toolbar key*
4. Expandable toolbar -> allows to switch between (2) and (3) with the expand toolbar key (current behavior, default)

(*) When incognito mode is on, the expand toolbar key will still be shown with the incognito icon but it won't allow expanding/collapsing the toolbar

I also tried to reduce some of the activity in the SuggestionStripView class depending on the selected mode.

fixes #732, fixes #374

[devycarol]

Sorry to intrude, but do you think it'd be simple to have "flex space" as an item in the toolbar key list? This way, you could have icons on both sides of the toolbar/suggestion strip.

Perhaps the toolbar could then be a simple toggle, and the expander position could be a list pref of "start, end, none." You could probably still auto show/hide the suggestions in the 'none' case.

This is really cool stuff! :)

[devycarol]

Why remove the variable toggle? Selecting 'variable' from a drop-down doesn't imply a particular direction preference for LTR/RTL.

Imo, the best approach would be a choice of how to initially place the expander (right, left, none) and a choice of whether to invert for RTL.

[herrbrixter]

4. Expandable toolbar -> allows to switch between (2) and (3) with the expand toolbar key (current behavior, default

For mode (4), please add a preference as to which toolbar is the default. The current behavior is:

a. Defaults to suggestion strip then can be switched to toolbar.

I want the reverse because I rarely use the suggestions. I use the copy, paste, select all more often.

b. Defaults to toolbar then can be switched to suggestion strip.

[CodeCubeNeo]

Maybe also add the option to just hide the toolbar (and suggestions) altogether?

[TitoCen]

How would I be able to use this? Thank you

[BlackyHawky]

@TitoCen The only way to use this feature is to compile the application yourself and integrate this PR or wait for Helium to take care of it and integrate it into a future release.

[The-Koala]

Just registered to Github for that specific thread : I never use the toolbar on keyboards, having the ability to remove it entirely would be awesome and free up some screen space ! 😍

[Pentaphon]

@Helium314 thoughts on this PR?

[Aryan-Chauhan]

Any updates on this PR?

[codokie]

@Helium314 has stated here that they have no plans to merge my pull requests, so don't expect to see this feature any time soon.

I would have tried to resolve the merge conflicts if they were to reconsider my contributions.

Anyone who is interested can fork it in order to submit a new PR; maybe their endeavors won't be dismissed by the repository owner.

[Pentaphon]

@codokie reading comments from the maintainer, it sounds like you aren't following his guidelines and there is simply no excuse for that. Every maintainer has specific guidelines people should follow to make the maintainer's job more efficient and you seem to disregarding them. That kind of behavior doesnt help your PRs nor this project as a whole. Please follow his guidelines if you expect to have your PRs merged.

[codokie]

@Pentaphon Honestly at this point I don't care any more if they merge my PRs since I've stopped using HeliBoard 6 months ago, but I would still be willing to fix merge conflicts and such, just because it seems there are some people (perhaps not you) who really look forward to that.

@Helium314 has stated they are not really interested to manage the issue part of this repository, so it's not surprising they are not excited when someone actually tries to help with that. It doesn't necessarily have anything to do with the guidelines, which this pull request doesn't really violate.

I've considered making my own fork because I'm clearly not welcome here, but the codebase is kind of a mess and I don't have a lot of time available right now..

[Pentaphon]

@codokie helium314 never said he is not interested in managing issues. He simply said he will not work on your issues until you follow his guidelines so just follow his guidelines and he will work on your PRs. It is as simple as that. There is no excuse for you to not to follow his guidelines.

[codokie]

@Pentaphon I really don't want to argue with you, but there is simply no excuse for those who don't verify their claims..

Did you even bother to read the last paragraph of @Helium314's rant?

I've never been interested in managing the issue / discussion part of a repository, it's more of a "necessary side effect". In principle I'm ok with taht, but it keeps taking more and more time. And already a while ago, the tons of non-development activity was too much for me, which resulted in reduced interest in my work here...

I intend to close all my pull requests real soon since they are being ignored anyway, so please don't sweat it.

Thank you for the support :pray:

[Pentaphon]

Did you even bother to read the last paragraph of @Helium314's rant?

@codokie I admittedly did not read that part due the line break that I didn't go past but the fact remains, you and Helium have a history where you do not follow his guidelines and he is simply tired of your noncompliance. If you simply complied with his guidelines, he wouldn't have any issues with you but you're ignoring him, complaining to him and just making things harder for him, so clearly the problem here is you. I suggest you extend an olive branch, admit that you could do better and fully comply with what he asks of his contributors so that your PRs get merged. Stop being hostile, and do with the maintainer asks so that he will merge your efforts in return. It's that simple.

[codokie]

@Pentaphon Very mature of you to thumbs down my comments..

Obviously you also missed the part where they said won't review any of my PRs any more.

So even if I wanted to improve, @Helium314 would just dismiss it out of spite..

I'm closing this pull request before this futile discussion escalates; it's no use for me to argue with you.

Apologies to those who have waited for this feature, it's just not something that's within my control.

[Pentaphon]

So even if I wanted to improve, Helium314 would just dismiss it out of spite..

You're just making excuses. If you apologized to him and started submitting PRs according to his guidelines as a show of good faith, he would probably work on them, but you want to do the old "take the ball and go home" routine instead of being a good sport. It's not too late to reverse course on your immature behavior so far but I have a feeling you just want to keep up this drama just because a maintainer dared to stand by his own guidelines, which you seem to perceive as a slight against you.

Apologies to those who have waited for this feature, it's just not something that's within my control.

It's absolutely within your control. You just refuse to admit fault and try to work well with others. Anybody reading this can see it.

It's still not too late. All you have to do is make amends and follow the guidelines and I'm sure the maintainer would be happy to work with you again.

[codokie]

@Pentaphon Ok so I'm the one to blame. Take care man.