HeliBoard icon indicating copy to clipboard operation
HeliBoard copied to clipboard

Display bug with inline suggestions

Open BlackyHawky opened this issue 2 months ago • 27 comments

Describe the bug See screenshot.

To Reproduce

  1. Click in the username field;
  2. Click in the password field;
  3. See the display bug.

Note: The display bug also occurs if the clipboard icon is not pinned.

Screenshot

App version 3.6 beta 1 + 3.6 beta 2

Device:

  • Model: Huawei + Samsung tablet
  • OS: Android 12 + Android 14

BlackyHawky avatar Nov 16 '25 20:11 BlackyHawky

I can't reproduce this. Would you test a debug build?

eranl avatar Nov 16 '25 23:11 eranl

I can't reproduce this.

I don't know if it's relevant, but during the test I only used the suggestion strip to display suggestions and nothing else.

Would you test a debug build?

Yes, I will test it.

BlackyHawky avatar Nov 17 '25 04:11 BlackyHawky

Please try https://github.com/eranl/HeliBoard/actions/runs/19444293375/artifacts/4593962666.

eranl avatar Nov 17 '25 21:11 eranl

Unfortunately, the same display bug occurs.

BlackyHawky avatar Nov 17 '25 21:11 BlackyHawky

I created another debug build, which removes the close button and adds logging. I would appreciate it if you could try it and:

  1. upload a screenshot for comparison
  2. upload the log file or just the line that starts with SuggestionStripView ... Display width

Thanks!

eranl avatar Nov 17 '25 23:11 eranl

Screenshot:

Log:


2025-11-18 06:00:11.647 D SuggestionStripView: Display width: 1344, suggestion strip view width: 1344, suggestions strip wrapper width: 1344, toolbarExpandKey width: 107, pinnedKeys width: 36, suggestionsStrip width: 1198, toolbarKeyLayoutParams.width: 107

BlackyHawky avatar Nov 18 '25 05:11 BlackyHawky

Thanks. Here's another attempt, bringing back the button, with 0 layout weight on the strip, which I hope fixes it.

eranl avatar Nov 18 '25 21:11 eranl

Unfortunately, it still doesn't work.

BlackyHawky avatar Nov 18 '25 22:11 BlackyHawky

Here's another tweak for you to test if you can please.

eranl avatar Nov 20 '25 01:11 eranl

Here's another tweak for you to test if you can please.

It still doesn't work, and it's identical to the last screenshot. 😬

Edit: It's strange that I'm the only one experiencing this display bug... 🤔

BlackyHawky avatar Nov 20 '25 05:11 BlackyHawky

It's strange that I'm the only one experiencing this display bug... 🤔

Possibly releated to your phone, or some specific setting.

Helium314 avatar Nov 20 '25 09:11 Helium314

Since we are talking about the positioning of a button, I don't see how my device would be involved. 🤔

Note:

  • Regardless of the resolution or display size of my device, the problem is the same.
  • Furthermore, I notice that if a clipboard entry is proposed as a suggestion, the incognito icon is not displayed if we are in the password field (I don't know if it's related).

BlackyHawky avatar Nov 20 '25 10:11 BlackyHawky

Since we are talking about the positioning of a button, I don't see how my device would be involved. 🤔

I remember device-specific issues on whether coloring a button works, so I assume this can also affect other parts of the view system.

Helium314 avatar Nov 20 '25 11:11 Helium314

FYI: I would like to remind you that the bug occurs if you first click on the username field and then on the password field.

If I click on the password field first, verything is working almost correctly.

Almost correctly, because the background of the icon is cut off when clicked. See the screenshot below.

Perhaps this will help you better identify the problem.

BlackyHawky avatar Nov 20 '25 15:11 BlackyHawky

I'm not able to reproduce even when following your exact scenario.

But here's another try.

eranl avatar Nov 20 '25 23:11 eranl

It still doesn't work.

In addition, my Samsung tablet with Android 14 is also affected by this display issue, so it is not related to my device. Below is a screenshot of version 3.6-beta2:

BlackyHawky avatar Nov 21 '25 05:11 BlackyHawky

Thanks. Here's another one. Whether it works or not, I would be curious to see the log lines starting with SuggestionStripView & InlineContentClipView.

eranl avatar Nov 22 '25 03:11 eranl

It still doesn't work. 😭 Maybe it's really because of my devices, but does that mean I'm really unlucky to have the only two devices that are incompatible with this feature? 🤔

Logs:

SuggestionStripView: Display width: 1344, suggestion strip view width: 1344, suggestions strip wrapper width: 1344, toolbarExpandKey width: 107, pinnedKeys width: 143, suggestionsStrip width: 1201, toolbarKeyLayoutParams.width: 107

InlineContentClipView: Clipping to Rect(0, 0 - 1094, 119)

Screenshot:


Edit: As I said in my previous comment, if I click directly in the password field, it works. Here is the log:


SuggestionStripView: Display width: 1344, suggestion strip view width: 1344, suggestions strip wrapper width: 1344, toolbarExpandKey width: 107, pinnedKeys width: 143, suggestionsStrip width: 1091, toolbarKeyLayoutParams.width: 107

InlineContentClipView: Clipping to Rect(0, 0 - 984, 119)

BlackyHawky avatar Nov 22 '25 06:11 BlackyHawky

Maybe it's really because of my devices, but does that mean I'm really unlucky to have the only two devices that are incompatible with this feature?

I guess it might be that not many people use the beta. Or it really is related to some specific setting.

I click directly in the password field, it works. Here is the log

Does the suggestion strip (except for the suggestions) look the same in both fields? Maybe some toolbar keys are added only after setting the inline suggestion. @eranl it might be possible to deal with this using View.doOn(Next)Layout. Or a coroutine with delay... but that's not ideal, and you might need to use runOnUiThread when touching the view.

Helium314 avatar Nov 22 '25 08:11 Helium314

@Helium314 @eranl

Or it really is related to some specific setting.

I found the source of the bug: as I said a few days ago: "I don't know if it's relevant, but during the test I only used the suggestion strip to display suggestions and nothing else."

Indeed, if I keep the toolbar settings at their default values, there are no display bugs. If I select "Suggestions only" the display bug occurs regardless of whether there is a pinned icon.

BlackyHawky avatar Nov 22 '25 12:11 BlackyHawky

Now I see what you meant by I only used the suggestion strip to display suggestions and nothing else. But even when setting to Suggestions only, I wasn't able to reproduce. However, it did give me a hint that it had something to do with the incognito button being shown, on your devices apparently after the external suggestions. So I manufactured a similar situation using delays, and was finally able to reproduce the bug you're seeing.

So that gives me some hope that this build will be the winner. Thanks @Helium314 for the doOnNextLayout tip.

eranl avatar Nov 23 '25 01:11 eranl

You've almost found the solution because it works about 3 time out of 4.

I'm sure the winner will be the next apk. 😉

Lastly, regarding one of my previous comments: "Furthermore, I notice that if a clipboard entry is proposed as a suggestion, the incognito icon is not displayed if we are in the password field (I don't know if it's related).

Is this related, or should I open another topic?

BlackyHawky avatar Nov 23 '25 06:11 BlackyHawky

I'm sure the winner will be the next apk. 😉

We'll see. 🙂

Lastly, regarding one of my previous comments: "Furthermore, I notice that if a clipboard entry is proposed as a suggestion, the incognito icon is not displayed if we are in the password field (I don't know if it's related).

Is this related, or should I open another topic?

Sorry I missed this note originally. It is related, and it actually gave me an idea for a simpler solution that seems to fix both issues.

eranl avatar Nov 23 '25 22:11 eranl

We will have to wait a little longer to announce the winner because it still isn't working.

The logs are identical to those previously provided.

The good thing is that the incognito icon appears when content is copied, which was not the case before.

BlackyHawky avatar Nov 24 '25 00:11 BlackyHawky

Looks like I was too eager to simplify... Please try this build.

eranl avatar Nov 24 '25 23:11 eranl

The behavior is strange and random: sometimes it works, sometimes it doesn't, and in rare cases the autofill pill does not appear in the username field.

As before, the case where it does not work is when "Suggestion only" is selected in the toolbar settings.

For your information, I don't do anything special during my tests: I click on the username field, then on the password field, then on the username field again, etc.

BlackyHawky avatar Nov 25 '25 00:11 BlackyHawky

Can you please provide the log entries for a working case and a non-working one? I'm mainly interested in the sequence of events and the clipping value.

eranl avatar Nov 25 '25 13:11 eranl