Key-Popup Menu Key Highlight Color Too Light

[SevenFactors]

trafficstars

Describe the bug

For all dark themes specially the black theme, the key-popup menu key highlight background color is too light/close to the background color. For the dynamic color themes (like in my case where the highlight is yellow) the text, which is white, blends too much into the highlight color. This makes it hard to distinguish which key/character is being highlighted.

This can be experienced on built-in themes, as well as, user-color-defined dark themes.

To Reproduce Select the Black, darker themes or define your own user-colors while setting the keyboard background black or a dark color.

Expected behavior I expect highlights to clearly standout from the background while keeping the text/character clearly readable and standing out from the highlight color.

It would be a welcomed feature for the highlight color key to be exposed under the common user-define colors or under the Show more colors and not buried within the Exposed All colors which are too much to edit and subject to change. For example. I am unable to load the color theme I created on the stable 2.3 on v3.0beta3 most likely this will be the same for v3.0stable

Screenshots ONLY add screenshots when they add real value. If you add screenshots, reduce the size or use thumbnails to keep the issue nicely readable.

App version v3.0beta3

Device:

• Model: Pixel5a
• OS: GOS

[Helium314]

I am unable to load the color theme I created on the stable 2.3 on v3.0beta3 most likely this will be the same for v3.0stable

Can you provide the theme so I can have a look?

[SevenFactors]

I am unable to load the color theme I created on the stable 2.3 on v3.0beta3 most likely this will be the same for v3.0stable

Can you provide the theme so I can have a look?

Sure. Here it is.

The way I try to load it is: setting/appearance/colors/ Then on the popup menu I press load. Look and select the file bu then nothing happen. It does not get added to the list nor applied. Just nothing happens.

FullColorsTheme.json

[Helium314]

The theme loading should work in the next version.

Is the too light color a new issue, or was it in older versions as well?

[SevenFactors]

The theme loading should work in the next version.

Is the too light color a new issue, or was it in older versions as well?

The highlight color being too light of a tone has been around on previous versions. This mostly affect dark themes. This is why I took the trial and error time to come up with a color theme via the "All Colors customizing interface" After seeing you were working on themes related stuff for the next milestone brought it forth to your attention.

Perhaps the color string dealing with highlight color (the highlight color for key pop-up menus eg: dot key) can it be brought forth into the regular color customization dialogs like: Main Colors or More Colors to make it easier to edit and more permanent? They All Colors panel clearly states that these can change at anytime.

Anyways, thank you.

[mattaw]

I also suffer from this bug. Here is Heliboard on the Signal messenger, and it is identical in Google Messages. Select a dark theme and provoke a spell check to trigger. It's been happening as long as I have used heliboard.

At a guess the code uses the light mode color for both themes, or maybe it's hard-coded?

I tried following the code in "app/src/main/java/helium314/keyboard/keyboard/PopupTextView.java" and rather got lost in the layers of how the class containing colors is built and updated.

[maruuk]

@mattaw This is most likely an Android bug. I even checked Gboard and FUTO and it's the same.