Stefano Borzì

Results 205 comments of Stefano Borzì

`RuntimeWarning: Couldn't find ffmpeg or avconv...` some libraries could use ffmpeg, be sure to have it installed. Moreover, try to give as input a sample with only one channel `ffmpeg...

We could archive this, it will not be updated, it's better to split the content into multiple modules. However, at the same time it's better to keep it open so...

Here is the no-repeat https://github.com/azerothcore/Keira3/blob/790101c50c6750d6a82798211b1e5b4be48b1be8/libs/shared/sai-editor/src/sai-comment-generator.service.ts#L982 The function to generate comments starts here https://github.com/azerothcore/Keira3/blob/master/libs/shared/sai-editor/src/sai-comment-generator.service.ts#L198 and it's a bit long, we should split it into multiple parts ideally

We have a lint rule that notifies if a component is not using the OnPush strategy, it's complaining about it ![image](https://github.com/user-attachments/assets/e10bf2f0-5e9e-4a0b-b7ca-e717cc8c53eb) [This is the issue reported by the pipeline](https://github.com/azerothcore/Keira3/actions/runs/12840836450/job/35809965943?pr=3256)

ok, I will test this PR locally and let you know ;-)

I don't dislike the approach but I am wondering if can be done only with: ```html ``` Without requiring any other information or adding components, because may you can find...

I was convinced that everything can be implemented inside the directive attribute making it agnostic and generic for all inputs without requiring any input information. ```typescript import { Directive, ElementRef,...

I noticed that, if we remove the control.touched contidion it should work on the first time too, I am not sure if it's 100% correct but we could remove it...

> I added a workaround, by adding markedAsTocuched() when the field is invalid. But maybe thats not as good as a solution as it can be? it could be in...

that is just to define the type, which is an int so `0` and not a string like `"0"`, moreover running ```sql DESCRIBE acore_world.creature_text; ``` I see that the default...