Godot-Multiplayer-Shooter icon indicating copy to clipboard operation
Godot-Multiplayer-Shooter copied to clipboard

Erase checking `OS.get_name()` as loop selects IP

Open cptchuckles opened this issue 4 years ago • 1 comments

cptchuckles avatar Jul 02 '21 20:07 cptchuckles

Good catch, I've asked in Godot's #networking discord channel and was recommended to match against the IETF/IANA address ranges

I omitted the check for ends_with(".1") because I didn't find anything specifying that that address was special; if you think it needs to be there, it would be easy to check for at the beginning of the loop and continue if found. FWIW my router's local address is .254 and not .1 like I expected, which is why I removed the check, because AFAICT one's local address might actually end with .1

cptchuckles avatar Jul 09 '21 19:07 cptchuckles