hekili icon indicating copy to clipboard operation
hekili copied to clipboard

Update PriestShadow.simc

Open syrifgit opened this issue 1 year ago • 3 comments

Fix shadowpriest opener to match SIMC and class guides. SW:Death was being skipped due to devouring plague requirement. This is not reflected in the sim.

syrifgit avatar Feb 24 '24 08:02 syrifgit

It's within margin of error, but may aswell have it correct: https://www.raidbots.com/simbot/report/cK3gXgJh52xBameBvhHfdg

syrifgit avatar Feb 24 '24 18:02 syrifgit

target_if doesn't really exist within the addon because secondary target data isn't kept available. It's possible you'd get the same results simply removing the cycle_targets=1 portion. The .simc file then needs to be imported, exported, and added to the RegisterPack for PriestShadow.lua.

Hekili avatar Mar 01 '24 17:03 Hekili

Probably can just change the line to this line instead which is what I did inside the addon to achieve the result. I was just trying my hand at a pull request lol. Of course the one I chose had something with no direction translation. :)

actions.aoe+=/shadow_word_death,if=(set_bonus.tier31_4pc|pet.fiend.active&talent.inescapable_torment&set_bonus.tier31_2pc)

syrifgit avatar Mar 01 '24 17:03 syrifgit