hekili icon indicating copy to clipboard operation
hekili copied to clipboard

SpellFlash: Use LibCustom Glow, Allow Other Shapes, etc.

Open brentrichardjr opened this issue 5 years ago • 10 comments

Action Bar highlighting is my favorite feature of Hekili. Other addons (e.g. WeakAuras, MaxDPS) take advantage of LibCustomGlow to expand the functionality and customization of button glows, including texture overlays. Any chance this could get integrated into Hekili?

brentrichardjr avatar Nov 21 '19 05:11 brentrichardjr

To be clear, what you want is for the SpellFlash feature to have more customization options? I can take a look.

Hekili avatar Nov 21 '19 13:11 Hekili

Exactly, thank you, I really appreciate it. I've tried MaxDPS addon in the past but I much prefer Hekili. The only thing I really liked from MaxDPS was the action bar customization. By default its a circle (Interface\Cooldowns\ping4), but could be changed to the glows like SpellFlash or Blizzard. I stumbled across the library after digging around in my addons folder, particularly weakauras2 (who's author contributes to LibCustomGlow). Seeing as SpellFlash isn't maintained anymore, I figured LibCustomGlow may be something you'd be interested in exploring.

brentrichardjr avatar Nov 21 '19 13:11 brentrichardjr

I've used LibCustomGlow (and it is packaged with the addon). However, the SpellFlash library is what locates abilities on your action bars and starts/stops the flash effect. I'll see if it's relatively trivial to use it to use LibCustomGlow flashes instead of its default.

Hekili avatar Nov 21 '19 14:11 Hekili

Please please :). Custom Texture would be perfect

dMopp avatar Jan 31 '21 17:01 dMopp

It's still an okay idea, just not at the top of my priority list.

Hekili avatar Feb 01 '21 23:02 Hekili

anyway to make the flash more noticeable? Spell flash hasn't been updated in 2yrs. It's VERY subtle

N6REJ avatar May 29 '21 12:05 N6REJ

Not a priority at this time.

Hekili avatar May 29 '21 12:05 Hekili

@Hekili ok.. I know at least 2 people who will stop using hekili because of it. for me, I like hekili just need to figure out the druid issue.

N6REJ avatar May 29 '21 23:05 N6REJ

This would be a feature I would use as well, FWIW.

Bigity avatar Jun 09 '21 18:06 Bigity

SpellFlashCore is in Public Domain, you can use any of currently working fork of it (eg from here).

Tga123 avatar Aug 06 '21 02:08 Tga123

Closing, as the addon has allowed customizing the SpellFlash glow for a long time. I have no plans to make use of LibCustomGlow.

Hekili avatar Mar 25 '23 18:03 Hekili