hekili icon indicating copy to clipboard operation
hekili copied to clipboard

[FEATURE] Enable SpellFlash on DominosActionButton

Open jaychang85 opened this issue 2 years ago • 3 comments

Before You Begin

  • [X] I confirm that I have downloaded the latest version of the addon.
  • [X] I am not playing on a private server.
  • [X] I checked for an existing, open ticket for this request and was not able to find one.
  • [X] I edited the title of this feature request (above) so that it describes the issue I am reporting.

Feature Request

FrameNames.Action = { "VFLButton", -- OpenRDX "DominosActionButton", -- Dominos }

I just added above line into Hekili\Libs\SpellFlashCore\SpellFlashCore.lua to enable SpellFlash on Dominos Action bar. See if you could update and release.

Additional Information

No response

Contact Information

No response

jaychang85 avatar Sep 03 '22 15:09 jaychang85

This would be better solved via modifying SpellFlashCore -- have you put in a ticket for that project?

https://github.com/Tga123/SpellFlashCore

Hekili avatar Sep 03 '22 15:09 Hekili

Sound good. Will open ticket to SpellFlashCore.

jaychang85 avatar Sep 03 '22 17:09 jaychang85

look like there is no way to open ticket to SpellFlashCore.

jaychang85 avatar Sep 03 '22 20:09 jaychang85

I believe you can submit a pull request without a ticket. Or you could a while back, when I did so.

Hekili avatar Sep 04 '22 13:09 Hekili

np. let me try pull request. no hurry. Just one line code I need to sync every time you have new update tho.

jaychang85 avatar Sep 04 '22 15:09 jaychang85

https://github.com/Tga123/SpellFlashCore/pull/2

jaychang85 avatar Sep 08 '22 04:09 jaychang85